Changeset 25364

Timestamp:

09/11/2013 09:47:14 PM (11 years ago)

Author:

wonderboymusic

Message:

Add a $post_id fixture to Tests_Comment_Query. Comments created without passing comment_post_ID produce an undefined variable notice in wp_insert_comment().

See #25282.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (4 diffs)

trunk/tests/phpunit/tests/comment/query.php

@@ -7 +7 @@
  */
 class Tests_Comment_Query extends WP_UnitTestCase {
-    var $comment_id;
+    protected $post_id;
+    protected $comment_id;
 
     function setUp() {
         parent::setUp();
+
+        $this->post_id = $this->factory->post->create();
     }
 
@@ -17 +20 @@
      */
     function test_get_comment_comment_approved_0() {
-        $comment_id = $this->factory->comment->create();
+        $comment_id = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
         $comments_approved_0 = get_comments( array( 'status' => 'hold' ) );
         $this->assertEquals( 0, count( $comments_approved_0 ) );
@@ -26 +29 @@
      */
     function test_get_comment_comment_approved_1() {
-        $comment_id = $this->factory->comment->create();
+        $comment_id = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
         $comments_approved_1 = get_comments( array( 'status' => 'approve' ) );
 
@@ -81 +84 @@
      */
     function test_orderby_meta() {
-        $comment_id = $this->factory->comment->create();
-        $comment_id2 = $this->factory->comment->create();
-        $comment_id3 = $this->factory->comment->create();
+        $comment_id = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
+        $comment_id2 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
+        $comment_id3 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
 
         add_comment_meta( $comment_id, 'key', 'value1', true );