Changeset 25374

Timestamp:

09/12/2013 04:01:34 AM (11 years ago)

Author:

wonderboymusic

Message:

Passing non-existent object properties to WP_UnitTestCase::assertNull() produces notices, opt instead for WP_UnitTestCase::assertTrue( empty( $obj->prop ) ) in tests/db.php.

See #25282.

File:

• trunk/tests/phpunit/tests/db.php (modified) (2 diffs)

trunk/tests/phpunit/tests/db.php

@@ -99 +99 @@
         $this->assertTrue( isset( $wpdb->dbh ) ); // Test __isset()
         unset( $wpdb->dbh );
-        $this->assertNull( $wpdb->dbh );
+        $this->assertTrue( empty( $wpdb->dbh ) );
         $wpdb->dbh = $dbh;
         $this->assertNotEmpty( $wpdb->dbh );
@@ -110 +110 @@
         global $wpdb;
 
-        $this->assertNull( $wpdb->nonexistent_property );
+        $this->assertTrue( empty( $wpdb->nonexistent_property ) );
         $wpdb->nonexistent_property = true;
         $this->assertTrue( $wpdb->nonexistent_property );
         $this->assertTrue( isset( $wpdb->nonexistent_property ) );
         unset( $wpdb->nonexistent_property );
-        $this->assertNull( $wpdb->nonexistent_property );
+        $this->assertTrue( empty( $wpdb->nonexistent_property ) );
     }