Changeset 25377 for trunk/tests/phpunit/tests/filters.php

Timestamp:

09/12/2013 04:16:59 AM (11 years ago)

Author:

wonderboymusic

Message:

Fix the PHP 5.4 Only variables should be passed by reference notices in tests/filters.php.

See #25282.

File:

• trunk/tests/phpunit/tests/filters.php (modified) (4 diffs)

trunk/tests/phpunit/tests/filters.php

@@ -21 +21 @@
         $this->assertEquals(array($tag), $a->get_tags());
 
-        $args = array_pop($a->get_args());
+        $argsvar = $a->get_args();
+        $args = array_pop( $argsvar );
         $this->assertEquals(array($val), $args);
     }
@@ -88 +89 @@
 
         $this->assertEquals(1, $a->get_call_count());
-        $this->assertEquals(array($val, $arg1), array_pop($a->get_args()));
+        $argsvar = $a->get_args();
+        $this->assertEquals( array( $val, $arg1 ), array_pop( $argsvar ) );
     }
 
@@ -107 +109 @@
         // a1 should be called with both args
         $this->assertEquals(1, $a1->get_call_count());
-        $this->assertEquals(array($val, $arg1, $arg2), array_pop($a1->get_args()));
+        $argsvar1 = $a1->get_args();
+        $this->assertEquals( array( $val, $arg1, $arg2 ), array_pop( $argsvar1 ) );
 
         // a2 should be called with one only
         $this->assertEquals(1, $a2->get_call_count());
-        $this->assertEquals(array($val), array_pop($a2->get_args()));
+        $argsvar2 = $a2->get_args();
+        $this->assertEquals( array( $val ), array_pop( $argsvar2 ) );
     }
 
@@ -247 +251 @@
     }
 
-        /**
-         * @ticket 21169
-         */
+    /**
+     * @ticket 21169
+     */
     function test_filter_removal_during_filter() {
         $tag = rand_str();