Changeset 25384

Timestamp:

09/12/2013 05:08:33 AM (11 years ago)

Author:

wonderboymusic

Message:

Use reset() to access the first element of an array, don't assume there is an item at index 0.

See #25282.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (1 diff)
• tests/phpunit/tests/term/getTerms.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -1239 +1239 @@
     $args['number'] = absint( $args['number'] );
     $args['offset'] = absint( $args['offset'] );
-    if ( !$single_taxonomy || !is_taxonomy_hierarchical($taxonomies[0]) ||
+    if ( !$single_taxonomy || ! is_taxonomy_hierarchical( reset( $taxonomies ) ) ||
         '' !== $args['parent'] ) {
         $args['child_of'] = 0;

trunk/tests/phpunit/tests/term/getTerms.php

@@ -86 +86 @@
         $term_id = $this->factory->tag->create();
         $terms = get_terms( array( '111' => 'post_tag' ), array( 'hide_empty' => false ) );
-        $this->assertEquals( $term_id, $terms[0]->term_id );
+        $this->assertEquals( $term_id, reset( $terms )->term_id );
     }