Make WordPress Core


Ignore:
Timestamp:
09/12/2013 02:47:58 PM (11 years ago)
Author:
wonderboymusic
Message:

There was way too much duplicated code in my notice cleanup, it built up over time, and there's definitely a need to standardize.

  • Remove duplicated code for deprecated function notice suppression
  • Add support in WP_UnitTestCase setUp/tearDown methods for $deprecated_functions fixture if the extending class has added it
  • Add a $deprecated_functions fixture to each extending class that needs it

To use this fixture, add something to your Test Case class like so:
protected $deprecated_functions = array( 'get_theme', 'get_themes', 'get_theme_data', 'get_current_theme' );

See #25282.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/media.php

    r25382 r25402  
    66 */
    77class Tests_Media extends WP_UnitTestCase {
     8    protected $deprecated_functions = array( 'wp_convert_bytes_to_hr' );
    89
    910    function setUp() {
     
    2021        $this->img_html = '<img src="' . $this->img_url . '"/>';
    2122        $this->img_dimensions = array( 'width' => 100, 'height' => 100 );
    22         add_action( 'deprecated_function_run', array( $this, 'deprecated_function_run' ) );
    23     }
    24 
    25     function tearDown() {
    26         parent::tearDown();
    27         remove_action( 'deprecated_function_run', array( $this, 'deprecated_function_run' ) );
    28     }
    29 
    30     function deprecated_function_run( $function ) {
    31         if ( in_array( $function, array( 'wp_convert_bytes_to_hr' ) ) )
    32             add_filter( 'deprecated_function_trigger_error', array( $this, 'deprecated_function_trigger_error' ) );
    33     }
    34 
    35     function deprecated_function_trigger_error() {
    36         remove_filter( 'deprecated_function_trigger_error', array( $this, 'deprecated_function_trigger_error' ) );
    37         return false;
    3823    }
    3924
Note: See TracChangeset for help on using the changeset viewer.