Make WordPress Core


Ignore:
Timestamp:
09/12/2013 02:47:58 PM (11 years ago)
Author:
wonderboymusic
Message:

There was way too much duplicated code in my notice cleanup, it built up over time, and there's definitely a need to standardize.

  • Remove duplicated code for deprecated function notice suppression
  • Add support in WP_UnitTestCase setUp/tearDown methods for $deprecated_functions fixture if the extending class has added it
  • Add a $deprecated_functions fixture to each extending class that needs it

To use this fixture, add something to your Test Case class like so:
protected $deprecated_functions = array( 'get_theme', 'get_themes', 'get_theme_data', 'get_current_theme' );

See #25282.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/ms.php

    r25397 r25402  
    99 */
    1010class Tests_MS extends WP_UnitTestCase {
    11 
     11    protected $deprecated_functions = array( 'is_blog_user', 'get_dashboard_blog' );
    1212    protected $plugin_hook_count = 0;
    1313
     
    1616
    1717        $_SERVER['REMOTE_ADDR'] = '';
    18         add_action( 'deprecated_function_run', array( $this, 'deprecated_function_run_check' ) );
    19     }
    20 
    21     function tearDown() {
    22         parent::tearDown();
    23         remove_action( 'deprecated_function_run', array( $this, 'deprecated_function_run_check' ) );
    24     }
    25 
    26     function deprecated_function_run_check( $function ) {
    27         if ( in_array( $function, array( 'is_blog_user', 'get_dashboard_blog' ) ) )
    28             add_filter( 'deprecated_function_trigger_error', array( $this, 'filter_deprecated_function_trigger_error' ) );
    29     }
    30 
    31     function filter_deprecated_function_trigger_error() {
    32         remove_filter( 'deprecated_function_trigger_error', array( $this, 'filter_deprecated_function_trigger_error' ) );
    33         return false;
    3418    }
    3519
Note: See TracChangeset for help on using the changeset viewer.