Changeset 25402 for trunk/tests/phpunit/tests/theme.php

Timestamp:

09/12/2013 02:47:58 PM (13 years ago)

Author:

wonderboymusic

Message:

There was way too much duplicated code in my notice cleanup, it built up over time, and there's definitely a need to standardize.

• Remove duplicated code for deprecated function notice suppression
• Add support in WP_UnitTestCase setUp/tearDown methods for $deprecated_functions fixture if the extending class has added it
• Add a $deprecated_functions fixture to each extending class that needs it

To use this fixture, add something to your Test Case class like so:
protected $deprecated_functions = array( 'get_theme', 'get_themes', 'get_theme_data', 'get_current_theme' );

See #25282.

File:

• trunk/tests/phpunit/tests/theme.php (modified) (3 diffs)

trunk/tests/phpunit/tests/theme.php

@@ -7 +7 @@
  */
 class Tests_Theme extends WP_UnitTestCase {
-
-    var $theme_slug = 'twentyeleven';
-    var $theme_name = 'Twenty Eleven';
+    protected $deprecated_functions = array( 'get_theme', 'get_themes', 'get_theme_data', 'get_current_theme' );
+    protected $theme_slug = 'twentyeleven';
+    protected $theme_name = 'Twenty Eleven';
 
     function setUp() {
@@ -16 +16 @@
         wp_clean_themes_cache();
         unset( $GLOBALS['wp_themes'] );
-
-        add_action( 'deprecated_function_run', array( $this, 'deprecated_function_run' ) );
     }
 
@@ -25 +23 @@
         unset( $GLOBALS['wp_themes'] );
         parent::tearDown();
-
-        remove_action( 'deprecated_function_run', array( $this, 'deprecated_function_run' ) );
-    }
-
-    function deprecated_function_run( $function ) {
-        if ( in_array( $function, array( 'get_theme', 'get_themes', 'get_theme_data', 'get_current_theme' ) ) )
-            add_filter( 'deprecated_function_trigger_error', array( $this, 'deprecated_function_trigger_error' ) );
-    }
-
-    function deprecated_function_trigger_error() {
-        remove_filter( 'deprecated_function_trigger_error', array( $this, 'deprecated_function_trigger_error' ) );
-        return false;
     }