Changeset 25433 for trunk/src/wp-admin/includes/comment.php

Timestamp:

09/13/2013 10:17:51 PM (11 years ago)

Author:

wonderboymusic

Message:

Fix some undefined index notices related to Comment unit tests:

• There are several places where a $_POST index was unchecked before setting a variable
• In wp_notify_postauthor(), $comment was being returned null, but its properties were being accessed.
• In check_ajax_referer(), 3 different values can be checked for nonce on $_REQUEST, but only 1 had an isset()

See #25282.

File:

• trunk/src/wp-admin/includes/comment.php (modified) (1 diff)

trunk/src/wp-admin/includes/comment.php

@@ -37 +37 @@
         wp_die ( __( 'You are not allowed to edit comments on this post.' ) );
 
-    $_POST['comment_author'] = $_POST['newcomment_author'];
-    $_POST['comment_author_email'] = $_POST['newcomment_author_email'];
-    $_POST['comment_author_url'] = $_POST['newcomment_author_url'];
-    $_POST['comment_approved'] = $_POST['comment_status'];
-    $_POST['comment_content'] = $_POST['content'];
-    $_POST['comment_ID'] = (int) $_POST['comment_ID'];
+    if ( isset( $_POST['newcomment_author'] ) )
+        $_POST['comment_author'] = $_POST['newcomment_author'];
+    if ( isset( $_POST['newcomment_author_email'] ) )
+        $_POST['comment_author_email'] = $_POST['newcomment_author_email'];
+    if ( isset( $_POST['newcomment_author_url'] ) )
+        $_POST['comment_author_url'] = $_POST['newcomment_author_url'];
+    if ( isset( $_POST['comment_status'] ) )
+        $_POST['comment_approved'] = $_POST['comment_status'];
+    if ( isset( $_POST['content'] ) )
+        $_POST['comment_content'] = $_POST['content'];
+    if ( isset( $_POST['comment_ID'] ) )
+        $_POST['comment_ID'] = (int) $_POST['comment_ID'];
 
     foreach ( array ('aa', 'mm', 'jj', 'hh', 'mn') as $timeunit ) {