Changeset 25546

Timestamp:

09/21/2013 10:50:09 AM (8 years ago)

Author:

ocean90

Message:

Trim leading whitespace from AJAX responses.

This fixes the warning "$(html) HTML strings must start with '<' character" by jQuery Migrate when adding nav menu items, post custom fields or comment replies.

fixes #23681.

Location:

trunk/src

Files:

• wp-admin/js/edit-comments.js (modified) (2 diffs)
• wp-admin/js/nav-menu.js (modified) (2 diffs)
• wp-includes/js/wp-lists.js (modified) (2 diffs)

trunk/src/wp-admin/js/edit-comments.js

@@ -496 +496 @@
 
         r = r.responses[0];
-        c = r.data;
         id = '#comment-' + r.id;
 
@@ -514 +513 @@
         }
 
+        c = $.trim(r.data); // Trim leading whitespaces
         $(c).hide()
         $('#replyrow').after(c);
+
         id = $(id);
         t.addEvents(id);

trunk/src/wp-admin/js/nav-menu.js

@@ -903 +903 @@
             $.post( ajaxurl, params, function(menuMarkup) {
                 var ins = $('#menu-instructions');
+
+                menuMarkup = $.trim( menuMarkup ); // Trim leading whitespaces
                 processMethod(menuMarkup, params);
+
                 // Make it stand out a bit more visually, by adding a fadeIn
                 $( 'li.pending' ).hide().fadeIn('slow');
@@ -909 +912 @@
                 if( ! ins.hasClass( 'menu-instructions-inactive' ) && ins.siblings().length )
                     ins.addClass( 'menu-instructions-inactive' );
+
                 callback();
             });

trunk/src/wp-includes/js/wp-lists.js

@@ -209 +209 @@
                 }).dequeue();
             }
-        }
+        };
 
         $.ajax( s );
@@ -309 +309 @@
 
     add: function( e, s ) {
-        e = $(e);
+        e = $( $.trim(e) ); // Trim leading whitespaces
 
         var list = $(this), old = false, _s = { pos: 0, id: 0, oldId: null }, ba, ref, color;