Changeset 25547

Timestamp:

09/21/2013 11:23:32 AM (6 years ago)

Author:

ocean90

Message:

Image Edit: Replace deprecated $.load() and $.error() methods to prevent warnings by jQuery Migrate, fixes #25371.

File:

• trunk/src/wp-admin/js/image-edit.js (modified) (1 diff)

trunk/src/wp-admin/js/image-edit.js

@@ -159 +159 @@
         };
 
-        img = $('<img id="image-preview-' + postid + '" />');
-        img.load( function() {
-            var max1, max2, parent = $('#imgedit-crop-' + postid), t = imageEdit;
-
-            parent.empty().append(img);
-
-            // w, h are the new full size dims
-            max1 = Math.max( t.hold.w, t.hold.h );
-            max2 = Math.max( $(img).width(), $(img).height() );
-            t.hold['sizer'] = max1 > max2 ? max2 / max1 : 1;
-
-            t.initCrop(postid, img, parent);
-            t.setCropSelection(postid, 0);
-
-            if ( (typeof callback != "unknown") && callback != null )
-                callback();
-
-            if ( $('#imgedit-history-' + postid).val() && $('#imgedit-undone-' + postid).val() == 0 )
-                $('input.imgedit-submit-btn', '#imgedit-panel-' + postid).removeAttr('disabled');
-            else
-                $('input.imgedit-submit-btn', '#imgedit-panel-' + postid).prop('disabled', true);
-
-            t.toggleEditor(postid, 0);
-        }).error(function(){
-            $('#imgedit-crop-' + postid).empty().append('<div class="error"><p>' + imageEditL10n.error + '</p></div>');
-            t.toggleEditor(postid, 0);
-        }).attr('src', ajaxurl + '?' + $.param(data));
+        img = $('<img id="image-preview-' + postid + '" />')
+            .on('load', function() {
+                var max1, max2, parent = $('#imgedit-crop-' + postid), t = imageEdit;
+
+                parent.empty().append(img);
+
+                // w, h are the new full size dims
+                max1 = Math.max( t.hold.w, t.hold.h );
+                max2 = Math.max( $(img).width(), $(img).height() );
+                t.hold['sizer'] = max1 > max2 ? max2 / max1 : 1;
+
+                t.initCrop(postid, img, parent);
+                t.setCropSelection(postid, 0);
+
+                if ( (typeof callback != "unknown") && callback != null )
+                    callback();
+
+                if ( $('#imgedit-history-' + postid).val() && $('#imgedit-undone-' + postid).val() == 0 )
+                    $('input.imgedit-submit-btn', '#imgedit-panel-' + postid).removeAttr('disabled');
+                else
+                    $('input.imgedit-submit-btn', '#imgedit-panel-' + postid).prop('disabled', true);
+
+                t.toggleEditor(postid, 0);
+            })
+            .on('error', function() {
+                $('#imgedit-crop-' + postid).empty().append('<div class="error"><p>' + imageEditL10n.error + '</p></div>');
+                t.toggleEditor(postid, 0);
+            })
+            .attr('src', ajaxurl + '?' + $.param(data));
     },