Changeset 25583 for trunk/src/wp-includes/meta.php

Timestamp:

09/23/2013 08:31:01 PM (12 years ago)

Author:

nacin

Message:

Return false in update_metadata() and update_metadata_by_mid() when the DB query fails.

props leewillis77.
fixes #24933.

File:

• trunk/src/wp-includes/meta.php (modified) (3 diffs)

trunk/src/wp-includes/meta.php

@@ -152 +152 @@
         do_action( 'update_postmeta', $meta_id, $object_id, $meta_key, $meta_value );
 
-    $wpdb->update( $table, $data, $where );
+    $result = $wpdb->update( $table, $data, $where );
+    if ( ! $result )
+        return false;
 
     wp_cache_delete($object_id, $meta_type . '_meta');
@@ -436 +438 @@
 
         // Run the update query, all fields in $data are %s, $where is a %d.
-        $result = (bool) $wpdb->update( $table, $data, $where, '%s', '%d' );
+        $result = $wpdb->update( $table, $data, $where, '%s', '%d' );
+        if ( ! $result )
+            return false;
 
         // Clear the caches.
@@ -446 +450 @@
             do_action( 'updated_postmeta', $meta_id, $object_id, $meta_key, $meta_value );
 
-        return $result;
+        return true;
     }