Changeset 25659

Timestamp:

10/02/2013 07:41:19 PM (10 years ago)

Author:

wonderboymusic

Message:

Make url_to_postid() work for custom post type URLs. Use get_post_types() and get_taxonomies() instead of directly accessing globals. Adds unit test.

Props faishal, for the globals fix.
Fixes #19744.

Location:

trunk

Files:

• src/wp-includes/class-wp.php (modified) (2 diffs)
• src/wp-includes/query.php (modified) (1 diff)
• src/wp-includes/rewrite.php (modified) (2 diffs)
• tests/phpunit/tests/rewrite.php (modified) (1 diff)

trunk/src/wp-includes/class-wp.php

@@ -239 +239 @@
         $this->public_query_vars = apply_filters('query_vars', $this->public_query_vars);
 
-        foreach ( $GLOBALS['wp_post_types'] as $post_type => $t )
+        foreach ( get_post_types( array(), 'objects' ) as $post_type => $t )
             if ( $t->query_var )
                 $post_type_query_vars[$t->query_var] = $post_type;
@@ -272 +272 @@
 
         // Convert urldecoded spaces back into +
-        foreach ( $GLOBALS['wp_taxonomies'] as $taxonomy => $t )
+        foreach ( get_taxonomies( array() , 'objects' ) as $taxonomy => $t )
             if ( $t->query_var && isset( $this->query_vars[$t->query_var] ) )
                 $this->query_vars[$t->query_var] = str_replace( ' ', '+', $this->query_vars[$t->query_var] );

trunk/src/wp-includes/query.php

@@ -1736 +1736 @@
         }
 
-        foreach ( $GLOBALS['wp_taxonomies'] as $taxonomy => $t ) {
+        foreach ( get_taxonomies( array() , 'objects' ) as $taxonomy => $t ) {
             if ( 'post_tag' == $taxonomy )
                 continue;   // Handled further down in the $q['tag'] block

trunk/src/wp-includes/rewrite.php

@@ -339 +339 @@
 
     $request = $url;
+    $post_type_query_vars = array();
+
+    foreach ( get_post_types( array() , 'objects' ) as $post_type => $t ) {
+        if ( ! empty( $t->query_var ) )
+            $post_type_query_vars[ $t->query_var ] = $post_type;
+    }
 
     // Look for matches.
@@ -366 +372 @@
             // Filter out non-public query vars
             global $wp;
-            parse_str($query, $query_vars);
+            parse_str( $query, $query_vars );
             $query = array();
             foreach ( (array) $query_vars as $key => $value ) {
-                if ( in_array($key, $wp->public_query_vars) )
+                if ( in_array( $key, $wp->public_query_vars ) ){
                     $query[$key] = $value;
+                    if ( isset( $post_type_query_vars[$key] ) ) {
+                        $query['post_type'] = $post_type_query_vars[$key];
+                        $query['name'] = $value;
+                    }
+                }
             }
 
             // Do the query
-            $query = new WP_Query($query);
-            if ( !empty($query->posts) && $query->is_singular )
+            $query = new WP_Query( $query );
+            if ( ! empty( $query->posts ) && $query->is_singular )
                 return $query->post->ID;
             else

trunk/tests/phpunit/tests/rewrite.php

@@ -33 +33 @@
     }
 
+    function test_url_to_postid_custom_post_type() {
+        delete_option( 'rewrite_rules' );
+        
+        $post_type = rand_str( 12 );
+        register_post_type( $post_type, array( 'public' => true ) );
+        
+        $id = $this->factory->post->create( array( 'post_type' => $post_type ) );
+        $this->assertEquals( $id, url_to_postid( get_permalink( $id ) ) );      
+        
+        _unregister_post_type( $post_type );        
+    }
+    
     function test_url_to_postid_hierarchical() {