Changeset 25708

Timestamp:

10/07/2013 01:37:00 PM (11 years ago)

Author:

nacin

Message:

Optimize the accessibility JS on the Menus screen to avoid browser crashes with very large menus.

props atimmer.
fixes #25112.

File:

• trunk/src/wp-admin/js/nav-menu.js (modified) (5 diffs)

trunk/src/wp-admin/js/nav-menu.js

@@ -404 +404 @@
 
             // Hide all links by default
-            $( '.menu-item-settings .field-move a' ).hide();
+            $( '.menu-item-settings .field-move a' ).css( 'display', 'none' );
 
             $( '.item-edit' ).each( function() {
@@ -410 +410 @@
                     movement = [],
                     availableMovement = '',
-                    menuItem = $this.parents( 'li.menu-item' ).first(),
+                    menuItem = $this.closest( 'li.menu-item' ).first(),
                     depth = menuItem.menuItemDepth(),
                     isPrimaryMenuItem = ( 0 === depth ),
-                    itemName = $this.parents( '.menu-item-handle' ).find( '.menu-item-title' ).text(),
+                    itemName = $this.closest( '.menu-item-handle' ).find( '.menu-item-title' ).text(),
                     position = parseInt( menuItem.index() ),
                     prevItemDepth = ( isPrimaryMenuItem ) ? depth : parseInt( depth - 1 ),
@@ -424 +424 @@
                 if ( 0 !== position ) {
                     var thisLink = menuItem.find( '.menus-move-up' );
-                    thisLink.prop( 'title', menus.moveUp ).show();
+                    thisLink.prop( 'title', menus.moveUp ).css( 'display', 'inline' );
                 }
 
                 if ( 0 !== position && isPrimaryMenuItem ) {
                     var thisLink = menuItem.find( '.menus-move-top' );
-                    thisLink.prop( 'title', menus.moveToTop ).show();
+                    thisLink.prop( 'title', menus.moveToTop ).css( 'display', 'inline' );
                 }
 
                 if ( position + 1 !== totalMenuItems && 0 !== position ) {
                     var thisLink = menuItem.find( '.menus-move-down' );
-                    thisLink.prop( 'title', menus.moveDown ).show();
+                    thisLink.prop( 'title', menus.moveDown ).css( 'display', 'inline' );
                 }
 
                 if ( 0 === position && 0 !== hasSameDepthSibling ) {
                     var thisLink = menuItem.find( '.menus-move-down' );
-                    thisLink.prop( 'title', menus.moveDown ).show();
+                    thisLink.prop( 'title', menus.moveDown ).css( 'display', 'inline' );
                 }
 
@@ -445 +445 @@
                     var thisLink = menuItem.find( '.menus-move-left' ),
                         thisLinkText = menus.outFrom.replace( '%s', prevItemNameLeft );
-                    thisLink.prop( 'title', menus.moveOutFrom.replace( '%s', prevItemNameLeft ) ).html( thisLinkText ).show();
+                    thisLink.prop( 'title', menus.moveOutFrom.replace( '%s', prevItemNameLeft ) ).html( thisLinkText ).css( 'display', 'inline' );
                 }
 
@@ -452 +452 @@
                         var thisLink = menuItem.find( '.menus-move-right' ),
                             thisLinkText = menus.under.replace( '%s', prevItemNameRight );
-                        thisLink.prop( 'title', menus.moveUnder.replace( '%s', prevItemNameRight ) ).html( thisLinkText ).show();
+                        thisLink.prop( 'title', menus.moveUnder.replace( '%s', prevItemNameRight ) ).html( thisLinkText ).css( 'display', 'inline' );
                     }
                 }