Changeset 25719

Timestamp:

10/07/2013 06:34:35 PM (12 years ago)

Author:

nacin

Message:

Move the revisions upgrade handler to POST, to avoid esoteric metadata stomping.

props SergeyBiryukov.
see #25023.
for trunk.

Location:

trunk/src/wp-admin

Files:

• edit-form-advanced.php (modified) (1 diff)
• includes/post.php (modified) (1 diff)

trunk/src/wp-admin/edit-form-advanced.php

@@ -115 +115 @@
     $revisions = wp_get_post_revisions( $post_ID );
 
-    // Check if the revisions have been upgraded
-    if ( ! empty( $revisions ) && _wp_get_post_revision_version( end( $revisions ) ) < 1 )
-        _wp_upgrade_revisions_of_post( $post, $revisions );
-
     // We should aim to show the revisions metabox only when there are revisions.
     if ( count( $revisions ) > 1 ) {

trunk/src/wp-admin/includes/post.php

@@ -177 +177 @@
         else
             wp_die( __('You are not allowed to edit this post.' ));
+    }
+
+    if ( post_type_supports( $ptype->name, 'revisions' ) ) {
+        $revisions = wp_get_post_revisions( $post_ID, array( 'order' => 'ASC', 'posts_per_page' => 1 ) );
+        $revision = current( $revisions );
+
+        // Check if the revisions have been upgraded
+        if ( $revisions && _wp_get_post_revision_version( $revision ) < 1 )
+            _wp_upgrade_revisions_of_post( $post, wp_get_post_revisions( $post_ID ) );
     }