Changeset 25741

Timestamp:

10/09/2013 06:46:34 PM (11 years ago)

Author:

helen

Message:

Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410.

File:

• trunk/src/wp-admin/includes/nav-menu.php (modified) (1 diff)

trunk/src/wp-admin/includes/nav-menu.php

@@ -300 +300 @@
         $output .= '<label class="menu-item-title">';
         $output .= '<input type="checkbox" class="menu-item-checkbox';
-        if ( property_exists( $item, 'front_or_home' ) && $item->front_or_home ) {
-            $title = sprintf( _x( 'Home: %s', 'nav menu front page title' ), get_the_title( $item->ID ) );
+
+        if ( ! empty( $item->front_or_home ) )
             $output .= ' add-to-top';
-        } elseif ( property_exists( $item, 'label' ) ) {
+
+        $output .= '" name="menu-item[' . $possible_object_id . '][menu-item-object-id]" value="'. esc_attr( $item->object_id ) .'" /> ';
+
+        if ( ! empty( $item->label ) ) {
             $title = $item->label;
-        }
-        $output .= '" name="menu-item[' . $possible_object_id . '][menu-item-object-id]" value="'. esc_attr( $item->object_id ) .'" /> ';
-        if ( isset( $item->post_type ) )
-            $output .= empty( $item->label ) ? esc_html( get_the_title( $item->ID ) ) : esc_html( $item->label );
-        else
-            $output .= isset( $title ) ? esc_html( $title ) : esc_html( $item->title );
+        } elseif ( isset( $item->post_type ) ) {
+            //duplicate_hook
+            $title = apply_filters( 'the_title', $item->post_title, $item->ID );
+            if ( ! empty( $item->front_or_home ) && _x( 'Home', 'nav menu home label' ) !== $title )
+                $title = sprintf( _x( 'Home: %s', 'nav menu front page title' ), $title );
+        }
+
+        $output .= isset( $title ) ? esc_html( $title ) : esc_html( $item->title );
         $output .= '</label>';