Changeset 25743

Timestamp:

10/09/2013 07:06:06 PM (12 years ago)

Author:

lancewillett

Message:

Twenty Fourteen: remove title attributes for better accessibility. Props sabreuse for original patch, see #25054.

Location:

trunk/src/wp-content/themes/twentyfourteen

Files:

• author.php (modified) (1 diff)
• content-aside.php (modified) (1 diff)
• content-featured-post.php (modified) (1 diff)
• content-gallery.php (modified) (2 diffs)
• content-image.php (modified) (1 diff)
• content-link.php (modified) (1 diff)
• content-quote.php (modified) (1 diff)
• content-video.php (modified) (1 diff)
• footer.php (modified) (1 diff)
• functions.php (modified) (1 diff)
• header.php (modified) (2 diffs)
• image.php (modified) (2 diffs)
• inc/template-tags.php (modified) (1 diff)
• inc/widgets.php (modified) (1 diff)

trunk/src/wp-content/themes/twentyfourteen/author.php

@@ -28 +28 @@
 
                         printf( __( 'All posts by %s', 'twentyfourteen' ), sprintf(
-                                '<span class="vcard"><a class="url fn n" href="%1$s" title="%2$s" rel="me">%3$s</a></span>',
+                                '<span class="vcard"><a class="url fn n" href="%1$s" rel="me">%2$s</a></span>',
                                 esc_url( get_author_posts_url( get_the_author_meta( 'ID' ) ) ),
-                                esc_attr( get_the_author() ),
                                 get_the_author()
                         ) );

trunk/src/wp-content/themes/twentyfourteen/content-aside.php

@@ -20 +20 @@
         <div class="entry-meta">
             <span class="post-format">
-                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'aside' ) ); ?>" title="<?php echo esc_attr( sprintf( __( 'All %s posts', 'twentyfourteen' ), get_post_format_string( 'aside' ) ) ); ?>"><?php echo get_post_format_string( 'aside' ); ?></a>
+                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'aside' ) ); ?>"><?php echo get_post_format_string( 'aside' ); ?></a>
             </span>
 

trunk/src/wp-content/themes/twentyfourteen/content-featured-post.php

@@ -7 +7 @@
 
 <article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
-    <a class="attachment-featured-featured" href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyfourteen' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="<?php the_ID(); ?>">
+    <a class="attachment-featured-featured" href="<?php the_permalink(); ?>" rel="<?php the_ID(); ?>">
         <?php
             if ( has_post_thumbnail() ) :

trunk/src/wp-content/themes/twentyfourteen/content-gallery.php

@@ -30 +30 @@
     </div>
     <?php elseif ( $image ) : ?>
-    <a class="attachment-featured-thumbnail" href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyfourteen' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="<?php the_ID(); ?>">
+    <a class="attachment-featured-thumbnail" href="<?php the_permalink(); ?>" rel="<?php the_ID(); ?>">
         <?php echo wp_get_attachment_image( $image, 'featured-thumbnail-large' ); ?>
     </a>
@@ -52 +52 @@
         <div class="entry-meta">
             <span class="post-format">
-                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'gallery' ) ); ?>" title="<?php echo esc_attr( sprintf( __( 'All %s posts', 'twentyfourteen' ), get_post_format_string( 'gallery' ) ) ); ?>"><?php echo get_post_format_string( 'gallery' ); ?></a>
+                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'gallery' ) ); ?>"><?php echo get_post_format_string( 'gallery' ); ?></a>
             </span>
 

trunk/src/wp-content/themes/twentyfourteen/content-image.php

@@ -28 +28 @@
         <div class="entry-meta">
             <span class="post-format">
-                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'image' ) ); ?>" title="<?php echo esc_attr( sprintf( __( 'All %s posts', 'twentyfourteen' ), get_post_format_string( 'image' ) ) ); ?>"><?php echo get_post_format_string( 'image' ); ?></a>
+                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'image' ) ); ?>"><?php echo get_post_format_string( 'image' ); ?></a>
             </span>
 

trunk/src/wp-content/themes/twentyfourteen/content-link.php

@@ -20 +20 @@
         <div class="entry-meta">
             <span class="post-format">
-                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'link' ) ); ?>" title="<?php echo esc_attr( sprintf( __( 'All %s posts', 'twentyfourteen' ), get_post_format_string( 'link' ) ) ); ?>"><?php echo get_post_format_string( 'link' ); ?></a>
+                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'link' ) ); ?>"><?php echo get_post_format_string( 'link' ); ?></a>
             </span>
 

trunk/src/wp-content/themes/twentyfourteen/content-quote.php

@@ -20 +20 @@
         <div class="entry-meta">
             <span class="post-format">
-                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'quote' ) ); ?>" title="<?php echo esc_attr( sprintf( __( 'All %s posts', 'twentyfourteen' ), get_post_format_string( 'quote' ) ) ); ?>"><?php echo get_post_format_string( 'quote' ); ?></a>
+                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'quote' ) ); ?>"><?php echo get_post_format_string( 'quote' ); ?></a>
             </span>
 

trunk/src/wp-content/themes/twentyfourteen/content-video.php

@@ -28 +28 @@
         <div class="entry-meta">
             <span class="post-format">
-                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'video' ) ); ?>" title="<?php echo esc_attr( sprintf( __( 'All %s posts', 'twentyfourteen' ), get_post_format_string( 'video' ) ) ); ?>"><?php echo get_post_format_string( 'video' ); ?></a>
+                <a class="entry-format" href="<?php echo esc_url( get_post_format_link( 'video' ) ); ?>"><?php echo get_post_format_string( 'video' ); ?></a>
             </span>
 

trunk/src/wp-content/themes/twentyfourteen/footer.php

@@ -19 +19 @@
             <div class="site-info">
                 <?php do_action( 'twentyfourteen_credits' ); ?>
-                <a href="<?php echo esc_url( __( 'http://wordpress.org/', 'twentyfourteen' ) ); ?>" title="<?php esc_attr_e( 'Semantic Personal Publishing Platform', 'twentyfourteen' ); ?>"><?php printf( __( 'Proudly powered by %s', 'twentyfourteen' ), 'WordPress' ); ?></a>
+                <a href="<?php echo esc_url( __( 'http://wordpress.org/', 'twentyfourteen' ) ); ?>"><?php printf( __( 'Proudly powered by %s', 'twentyfourteen' ), 'WordPress' ); ?></a>
             </div><!-- .site-info -->
         </footer><!-- #colophon -->

trunk/src/wp-content/themes/twentyfourteen/functions.php

@@ -333 +333 @@
     }
 
-    printf( '<a href="%1$s" title="%2$s" rel="attachment">%3$s</a>',
+    printf( '<a href="%1$s" rel="attachment">%2$s</a>',
         esc_url( $next_attachment_url ),
-        the_title_attribute( array( 'echo' => false ) ),
         wp_get_attachment_image( $post->ID, $attachment_size )
     );

trunk/src/wp-content/themes/twentyfourteen/header.php

@@ -29 +29 @@
     <?php if ( get_header_image() ) : ?>
     <div id="site-header">
-        <a href="<?php echo esc_url( home_url( '/' ) ); ?>" title="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>" rel="home">
+        <a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home">
             <img src="<?php header_image(); ?>" width="<?php echo get_custom_header()->width; ?>" height="<?php echo get_custom_header()->height; ?>" alt="" />
         </a>
@@ -37 +37 @@
     <header id="masthead" class="site-header" role="banner">
         <div class="header-main">
-            <h1 class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" title="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></h1>
+            <h1 class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></h1>
 
             <div class="header-extra">

trunk/src/wp-content/themes/twentyfourteen/image.php

@@ -25 +25 @@
                     <span class="entry-date"><time class="entry-date" datetime="<?php echo esc_attr( get_the_date( 'c' ) ); ?>"><?php echo esc_html( get_the_date() ); ?></time></span>
 
-                    <span class="full-size-link"><a href="<?php echo wp_get_attachment_url(); ?>" title="Link to full-size image"><?php echo $metadata['width']; ?> &times; <?php echo $metadata['height']; ?></a></span>
+                    <span class="full-size-link"><a href="<?php echo wp_get_attachment_url(); ?>"><?php echo $metadata['width']; ?> &times; <?php echo $metadata['height']; ?></a></span>
 
-                    <span class="parent-post-link"><a href="<?php echo get_permalink( $post->post_parent ); ?>" title="Return to <?php echo esc_attr( get_the_title( $post->post_parent ) ); ?>" rel="gallery"><?php echo get_the_title( $post->post_parent ); ?></a></span>
+                    <span class="parent-post-link"><a href="<?php echo get_permalink( $post->post_parent ); ?>" rel="gallery"><?php echo get_the_title( $post->post_parent ); ?></a></span>
                     <?php edit_post_link( __( 'Edit', 'twentyfourteen' ), '<span class="edit-link">', '</span>' ); ?>
                 </div><!-- .entry-meta -->
@@ -59 +59 @@
                 <?php
                     if ( comments_open() && pings_open() ) : // Comments and trackbacks open
-                        printf( __( '<a class="comment-link" href="#respond" title="Post a comment">Post a comment</a> or leave a trackback: <a class="trackback-link" href="%s" title="Trackback URL for your post" rel="trackback">Trackback URL</a>.', 'twentyfourteen' ), get_trackback_url() );
+                        printf( __( '<a class="comment-link" href="#respond">Post a comment</a> or leave a trackback: <a class="trackback-link" href="%s" rel="trackback">Trackback URL</a>.', 'twentyfourteen' ), get_trackback_url() );
                     elseif ( ! comments_open() && pings_open() ) : // Only trackbacks open
-                        printf( __( 'Comments are closed, but you can leave a trackback: <a class="trackback-link" href="%s" title="Trackback URL for your post" rel="trackback">Trackback URL</a>.', 'twentyfourteen' ), get_trackback_url() );
+                        printf( __( 'Comments are closed, but you can leave a trackback: <a class="trackback-link" href="%s" rel="trackback">Trackback URL</a>.', 'twentyfourteen' ), get_trackback_url() );
                     elseif ( comments_open() && ! pings_open() ) : // Only comments open
-                        _e( 'Trackbacks are closed, but you can <a class="comment-link" href="#respond" title="Post a comment">post a comment</a>.', 'twentyfourteen' );
+                        _e( 'Trackbacks are closed, but you can <a class="comment-link" href="#respond">post a comment</a>.', 'twentyfourteen' );
                     elseif ( ! comments_open() && ! pings_open() ) : // Comments and trackbacks closed
                         _e( 'Both comments and trackbacks are currently closed.', 'twentyfourteen' );

trunk/src/wp-content/themes/twentyfourteen/inc/template-tags.php

@@ -95 +95 @@
         echo '<span class="featured-post">' . __( 'Sticky', 'twentyfourteen' ) . '</span>';
 
-    printf( __( '<span class="entry-date"><a href="%1$s" title="%2$s" rel="bookmark"><time class="entry-date" datetime="%3$s">%4$s</time></a></span> <span class="byline"><span class="author vcard"><a class="url fn n" href="%5$s" title="%6$s" rel="author">%7$s</a></span></span>', 'twentyfourteen' ),
+    printf( __( '<span class="entry-date"><a href="%1$s" rel="bookmark"><time class="entry-date" datetime="%2$s">%3$s</time></a></span> <span class="byline"><span class="author vcard"><a class="url fn n" href="%4$s" rel="author">%5$s</a></span></span>', 'twentyfourteen' ),
         esc_url( get_permalink() ),
-        esc_attr( get_the_time() ),
         esc_attr( get_the_date( 'c' ) ),
         esc_html( get_the_date() ),
         esc_url( get_author_posts_url( get_the_author_meta( 'ID' ) ) ),
-        esc_attr( sprintf( __( 'View all posts by %s', 'twentyfourteen' ), get_the_author() ) ),
         get_the_author()
     );

trunk/src/wp-content/themes/twentyfourteen/inc/widgets.php

@@ -157 +157 @@
                                 endif;
 
-                                printf( __( '<span class="entry-date"><a href="%1$s" title="%2$s" rel="bookmark"><time class="entry-date" datetime="%3$s">%4$s</time></a></span> <span class="byline"><span class="author vcard"><a class="url fn n" href="%5$s" title="%6$s" rel="author">%7$s</a></span></span>', 'twentyfourteen' ),
+                                printf( __( '<span class="entry-date"><a href="%1$s" rel="bookmark"><time class="entry-date" datetime="%2$s">%3$s</time></a></span> <span class="byline"><span class="author vcard"><a class="url fn n" href="%4$s" rel="author">%5s</a></span></span>', 'twentyfourteen' ),
                                     esc_url( get_permalink() ),
-                                    esc_attr( get_the_time() ),
                                     esc_attr( get_the_date( 'c' ) ),
                                     esc_html( get_the_date() ),
                                     esc_url( get_author_posts_url( get_the_author_meta( 'ID' ) ) ),
-                                    esc_attr( sprintf( __( 'View all posts by %s', 'twentyfourteen' ), get_the_author() ) ),
                                     get_the_author()
                                 );