Changeset 25838 for trunk/src/wp-admin/includes/schema.php

Timestamp:

10/18/2013 07:47:44 AM (11 years ago)

Author:

nacin

Message:

Delete expired transients on database upgrades.

Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.

File:

• trunk/src/wp-admin/includes/schema.php (modified) (1 diff)

trunk/src/wp-admin/includes/schema.php

@@ -547 +547 @@
     // delete obsolete magpie stuff
     $wpdb->query("DELETE FROM $wpdb->options WHERE option_name REGEXP '^rss_[0-9a-f]{32}(_ts)?$'");
-    // clear transient data
-    $wpdb->query( "DELETE FROM $wpdb->options WHERE option_name LIKE '\_transient\_%' OR option_name LIKE '\_site\_transient\_%'" );
+
+    // Deletes all expired transients.
+    // The multi-table delete syntax is used to delete the transient record from table a,
+    // and the corresponding transient_timeout record from table b.
+    $time = time();
+    $wpdb->query("DELETE a, b FROM $wpdb->options a, $wpdb->options b WHERE
+            a.option_name LIKE '\_transient\_%' AND
+            a.option_name NOT LIKE '\_transient\_timeout\_%' AND
+            b.option_name = CONCAT( '_transient_timeout_', SUBSTRING( a.option_name, 12 ) )
+            AND b.option_value < $time");
+
+    if ( is_main_site() && is_main_network() ) {
+        $wpdb->query("DELETE a, b FROM $wpdb->options a, $wpdb->options b WHERE
+            a.option_name LIKE '\_site\_transient\_%' AND
+            a.option_name NOT LIKE '\_site\_transient\_timeout\_%' AND
+            b.option_name = CONCAT( '_site_transient_timeout_', SUBSTRING( a.option_name, 17 ) )
+            AND b.option_value < $time");
+    }
 }