Changeset 26040

Timestamp:

11/07/2013 08:40:12 PM (11 years ago)

Author:

nacin

Message:

Use only one var per scope in our password-strength-meter tests.

props kadamwhite.
see #25187.

File:

• trunk/tests/qunit/wp-admin/js/password-strength-meter.js (modified) (3 diffs)

trunk/tests/qunit/wp-admin/js/password-strength-meter.js

@@ -13 +13 @@
     test( 'long complicated passwords should return 4', function() {
         var password = function( length ) {
-            var possibility = 'abcdefghijklnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789',
-                retVal = '';
-            for ( var i = 0, n = possibility.length; i < length; i++ ) {
+            var i, n, retVal = '',
+                possibility = 'abcdefghijklnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';
+            for ( i = 0, n = possibility.length; i < length; i++ ) {
                 retVal += possibility.charAt( Math.floor( Math.random() * n ) );
             }
@@ -37 +37 @@
 
     test( 'zxcvbn password tests should return the score we expect', function() {
-        var passwords = [
+        var passwords, i;
+        passwords = [
             { pw: 'zxcvbn', score: 0 },
             { pw: 'qwER43@!', score: 1 },
@@ -74 +75 @@
         ];
 
-        for ( var i = 0; i < passwords.length; i++ ) {
+        for ( i = 0; i < passwords.length; i++ ) {
             equal( passwordStrength( passwords[i].pw, 'username', passwords[i].pw ), passwords[i].score, 'password of `' + passwords[i].pw + '` returns ' + passwords[i].score );
         }