Changeset 26112

Timestamp:

11/12/2013 11:55:23 PM (12 years ago)

Author:

nacin

Message:

Free common.js of JSHint errors.

props jorbin.
fixes #25912.

File:

• trunk/src/wp-admin/js/common.js (modified) (9 diffs)

trunk/src/wp-admin/js/common.js

@@ +1 @@
+/* global setUserSetting, ajaxurl, commonL10n, alert, confirm, toggleWithKeyboard, pagenow */
 var showNotice, adminMenu, columns, validateForm, screenMeta;
 (function($){
@@ -66 +67 @@
         $t.attr('colspan', n.toString());
     }
-}
+};
 
 $(document).ready(function(){columns.init();});
 
 validateForm = function( form ) {
-    return !$( form ).find('.form-required').filter( function() { return $('input:visible', this).val() == ''; } ).addClass( 'form-invalid' ).find('input:visible').change( function() { $(this).closest('.form-invalid').removeClass( 'form-invalid' ); } ).size();
-}
+    return !$( form )
+        .find( '.form-required' )
+        .filter( function() { return $( 'input:visible', this ).val() === ''; } )
+        .addClass( 'form-invalid' )
+        .find( 'input:visible' )
+        .change( function() { $( this ).closest( '.form-invalid' ).removeClass( 'form-invalid' ); } )
+        .size();
+};
 
 // stub for doing better warnings
@@ -161 +168 @@
 
 $(document).ready( function() {
-    var lastClicked = false, checks, first, last, checked, sliced, menu = $('#adminmenu'), mobileEvent,
-        pageInput = $('input.current-page'), currentPage = pageInput.val();
+    var checks, first, last, checked, sliced, mobileEvent, transitionTimeout, focusedRowActions,
+        lastClicked = false,
+        menu = $('#adminmenu'),
+        pageInput = $('input.current-page'),
+        currentPage = pageInput.val();
 
     // when the menu is folded, make the fly-out submenu header clickable
@@ -169 +179 @@
     });
 
-    $('#collapse-menu').on('click.collapse-menu', function(e){
+    $('#collapse-menu').on('click.collapse-menu', function() {
         var body = $( document.body ), respWidth;
 
@@ -227 +237 @@
 
     menu.find('li.wp-has-submenu').hoverIntent({
-        over: function(e){
+        over: function() {
             var b, h, o, f, m = $(this).find('.wp-submenu'), menutop, wintop, maxtop, top = parseInt( m.css('top'), 10 );
 
@@ -301 +311 @@
         var unchecked = $(this).closest('tbody').find(':checkbox').filter(':visible').not(':checked');
         $(this).closest('table').children('thead, tfoot').find(':checkbox').prop('checked', function() {
-            return ( 0 == unchecked.length );
+            return ( 0 === unchecked.length );
         });
 
@@ -336 +346 @@
 
     // Show row actions on keyboard focus of its parent container element or any other elements contained within
-    var transitionTimeout, focusedRowActions;
     $( 'td.post-title, td.title, td.comment, .bookmarks td.column-name, td.blogname, td.username, .dashboard-comment-wrap' ).focusin(function(){
         clearTimeout( transitionTimeout );
@@ -397 +406 @@
     });
 
-    $('#newcontent').bind('blur.wpevent_InsertTab', function(e) {
+    $('#newcontent').bind('blur.wpevent_InsertTab', function() {
         if ( this.lastKey && 9 == this.lastKey )
             this.focus();
@@ -403 +412 @@
 
     if ( pageInput.length ) {
-        pageInput.closest('form').submit( function(e){
+        pageInput.closest('form').submit( function() {
 
             // Reset paging var for new filters/searches but not for bulk actions. See #17685.