Changeset 26161

Timestamp:

11/14/2013 05:53:15 AM (7 years ago)

Author:

nacin

Message:

Fix JSHint errors in media-views.js.

props kadamwhite.
fixes #25974.

File:

• trunk/src/wp-includes/js/media-views.js (modified) (17 diffs)

trunk/src/wp-includes/js/media-views.js

@@ +1 @@
+/* global _wpMediaViewsL10n, confirm, getUserSetting, setUserSetting */
 (function($){
     var media       = wp.media,
         Attachment  = media.model.Attachment,
         Attachments = media.model.Attachments,
-        Query       = media.model.Query,
         l10n;
 
@@ -119 +119 @@
 
         trigger: function( event ) {
-            var base;
+            var base, args;
+
             if ( ! this._mode )
                 return;
 
-            var args = _.toArray( arguments );
+            args = _.toArray( arguments );
             base = this.id + ':' + event;
 
@@ -456 +457 @@
 
         defaultDisplaySettings: function( attachment ) {
-            settings = this._defaultDisplaySettings;
+            var settings = this._defaultDisplaySettings;
             if ( settings.canEmbed = this.canEmbed( attachment ) )
                 settings.link = 'embed';
@@ -496 +497 @@
         recordSelection: function() {
             var selection = this.get('selection'),
-                manager = this.frame._selection,
-                filtered;
+                manager = this.frame._selection;
 
             if ( ! this.get('syncSelection') || ! manager || ! selection )
@@ -1060 +1060 @@
             // Generate the tab states.
             _.each( tabs, function( title, id ) {
-                var frame = this.state( 'iframe:' + id ).set( _.defaults({
+                this.state( 'iframe:' + id ).set( _.defaults({
                     tab:     id,
                     src:     tabUrl + '&tab=' + id,
@@ -1124 +1124 @@
     // Map some of the modal's methods to the frame.
     _.each(['open','close','attach','detach','escape'], function( method ) {
-        media.view.MediaFrame.prototype[ method ] = function( view ) {
+        media.view.MediaFrame.prototype[ method ] = function() {
             if ( this.modal )
                 this.modal[ method ].apply( this.modal, arguments );
@@ -1151 +1151 @@
 
         createSelection: function() {
-            var controller = this,
-                selection = this.options.selection;
+            var selection = this.options.selection;
 
             if ( ! (selection instanceof media.model.Selection) ) {
@@ -1932 +1931 @@
         progress: function() {
             var queue = this.queue,
-                $bar = this.$bar,
-                memo = 0;
+                $bar = this.$bar;
 
             if ( ! $bar || ! queue.length )
@@ -2112 +2110 @@
     media.view.Toolbar.Select = media.view.Toolbar.extend({
         initialize: function() {
-            var options = this.options,
-                controller = options.controller,
-                selection = controller.state().get('selection');
+            var options = this.options;
 
             _.bindAll( this, 'clickSelect' );
@@ -2619 +2615 @@
                 model = this.model,
                 method = options && options.method,
-                single, between, models, singleIndex, modelIndex;
+                single, models, singleIndex, modelIndex;
 
             if ( ! selection )
@@ -2900 +2896 @@
             this._viewsByCid = {};
 
-            this.collection.on( 'add', function( attachment, attachments, options ) {
+            this.collection.on( 'add', function( attachment ) {
                 this.views.add( this.createAttachmentView( attachment ), {
                     at: this.collection.indexOf( attachment )
@@ -2906 +2902 @@
             }, this );
 
-            this.collection.on( 'remove', function( attachment, attachments, options ) {
+            this.collection.on( 'remove', function( attachment ) {
                 var view = this._viewsByCid[ attachment.cid ];
                 delete this._viewsByCid[ attachment.cid ];
@@ -3067 +3063 @@
         },
 
-        scroll: function( event ) {
+        scroll: function() {
             // @todo: is this still necessary?
             if ( ! this.$el.is(':visible') )
@@ -3150 +3146 @@
         },
 
-        change: function( event ) {
+        change: function() {
             var filter = this.filters[ this.el.value ];
 
@@ -3397 +3393 @@
         createSingle: function() {
             var sidebar = this.sidebar,
-                single = this.options.selection.single(),
-                views = {};
+                single = this.options.selection.single();
 
             sidebar.set( 'details', new media.view.Attachment.Details({
@@ -3631 +3626 @@
         },
 
-        updateChanges: function( model, options ) {
+        updateChanges: function( model ) {
             if ( model.hasChanged() )
                 _( model.changed ).chain().keys().each( this.update, this );
@@ -3757 +3752 @@
         },
 
-        editAttachment: function( event ) {
+        editAttachment: function() {
             this.$el.addClass('needs-refresh');
         },