Changeset 26193

Timestamp:

11/15/2013 04:27:31 AM (12 years ago)

Author:

nacin

Message:

Fix JSHint errors in wplink.js.

props jorbin.
fixes #25914.

File:

• trunk/src/wp-includes/js/wplink.js (modified) (11 diffs)

trunk/src/wp-includes/js/wplink.js

@@ +1 @@
+/* global ajaxurl, tinymce, wpLinkL10n, tinyMCEPopup, setUserSetting, wpActiveEditor */
 var wpLink;
 
@@ -114 +115 @@
                 inputs.title.val( ed.dom.getAttrib(e, 'title') );
                 // Set open in new tab.
-                inputs.openInNewTab.prop('checked', ( "_blank" == ed.dom.getAttrib( e, 'target' ) ) );
+                inputs.openInNewTab.prop('checked', ( '_blank' == ed.dom.getAttrib( e, 'target' ) ) );
                 // Update save prompt.
                 inputs.submit.val( wpLinkL10n.update );
@@ -157 +158 @@
 
         htmlUpdate : function() {
-            var attrs, html, begin, end, cursor,
+            var attrs, html, begin, end, cursor, selection,
                 textarea = wpLink.textarea;
 
@@ -202 +203 @@
                     cursor -= '</a>'.length;
 
-                textarea.value = textarea.value.substring( 0, begin )
-                               + html
-                               + textarea.value.substring( end, textarea.value.length );
+                textarea.value = textarea.value.substring( 0, begin ) + html +
+                    textarea.value.substring( end, textarea.value.length );
 
                 // Update cursor position
@@ -228 +228 @@
                     ed.dom.remove(e, 1);
                     ed.selection.moveToBookmark(b);
-                    tinyMCEPopup.execCommand("mceEndUndoLevel");
+                    tinyMCEPopup.execCommand('mceEndUndoLevel');
                     wpLink.close();
                 }
@@ -235 +235 @@
 
             if (e == null) {
-                ed.getDoc().execCommand("unlink", false, null);
-                tinyMCEPopup.execCommand("mceInsertLink", false, "#mce_temp_url#", {skip_undo : 1});
-
-                tinymce.each(ed.dom.select("a"), function(n) {
+                ed.getDoc().execCommand('unlink', false, null);
+                tinyMCEPopup.execCommand('mceInsertLink', false, '#mce_temp_url#', {skip_undo : 1});
+
+                tinymce.each(ed.dom.select('a'), function(n) {
                     if (ed.dom.getAttrib(n, 'href') == '#mce_temp_url#') {
                         e = n;
@@ -263 +263 @@
             }
 
-            ed.execCommand("mceEndUndoLevel");
+            ed.execCommand('mceEndUndoLevel');
             wpLink.close();
             ed.focus();
@@ -271 +271 @@
             inputs.url.val( li.children('.item-permalink').val() );
             inputs.title.val( li.hasClass('no-title') ? '' : li.children('.item-title').text() );
-            if ( originalEvent && originalEvent.type == "click" )
+            if ( originalEvent && originalEvent.type == 'click' )
                 inputs.url.focus();
         },
@@ -319 +319 @@
             var fn, key = $.ui.keyCode;
 
-            switch( event.which ) {
-                case key.UP:
-                    fn = 'prev';
-                case key.DOWN:
-                    fn = fn || 'next';
-                    clearInterval( wpLink.keyInterval );
-                    wpLink[ fn ]();
-                    wpLink.keyInterval = setInterval( wpLink[ fn ], wpLink.keySensitivity );
-                    break;
-                default:
-                    return;
-            }
+            if ( event.which !== key.UP && event.which !== key.DOWN ) {
+                return;
+            }
+
+            fn = event.which === key.UP ? 'prev' : 'next';
+            clearInterval( wpLink.keyInterval );
+            wpLink[ fn ]();
+            wpLink.keyInterval = setInterval( wpLink[ fn ], wpLink.keySensitivity );
             event.preventDefault();
         },
+
         keyup: function( event ) {
             var key = $.ui.keyCode;
 
-            switch( event.which ) {
-                case key.ESCAPE:
-                    event.stopImmediatePropagation();
-                    if ( ! $(document).triggerHandler( 'wp_CloseOnEscape', [{ event: event, what: 'wplink', cb: wpLink.close }] ) )
-                        wpLink.close();
-
-                    return false;
-                    break;
-                case key.UP:
-                case key.DOWN:
-                    clearInterval( wpLink.keyInterval );
-                    break;
-                default:
-                    return;
-            }
-            event.preventDefault();
+            if ( event.which === key.ESCAPE ) {
+                event.stopImmediatePropagation();
+                if ( ! $(document).triggerHandler( 'wp_CloseOnEscape', [{ event: event, what: 'wplink', cb: wpLink.close }] ) )
+                    wpLink.close();
+                return false;
+            }
+
+            if ( event.which === key.UP || event.which === key.DOWN ) {
+                clearInterval( wpLink.keyInterval );
+                event.preventDefault();
+            }
         },
 
@@ -508 +500 @@
             if ( !results ) {
                 if ( firstPage ) {
-                    list += '<li class="unselectable"><span class="item-title"><em>'
-                    + wpLinkL10n.noMatchesFound
-                    + '</em></span></li>';
+                    list += '<li class="unselectable"><span class="item-title"><em>' +
+                        wpLinkL10n.noMatchesFound + '</em></span></li>';
                 }
             } else {
                 $.each( results, function() {
                     classes = alt ? 'alternate' : '';
-                    classes += this['title'] ? '' : ' no-title';
+                    classes += this.title ? '' : ' no-title';
                     list += classes ? '<li class="' + classes + '">' : '<li>';
-                    list += '<input type="hidden" class="item-permalink" value="' + this['permalink'] + '" />';
+                    list += '<input type="hidden" class="item-permalink" value="' + this.permalink + '" />';
                     list += '<span class="item-title">';
-                    list += this['title'] ? this['title'] : wpLinkL10n.noTitle;
-                    list += '</span><span class="item-info">' + this['info'] + '</span></li>';
+                    list += this.title ? this.title : wpLinkL10n.noTitle;
+                    list += '</span><span class="item-info">' + this.info + '</span></li>';
                     alt = ! alt;
                 });
@@ -579 +570 @@
                 self.allLoaded = !r;
                 callback( r, query );
-            }, "json" );
+            }, 'json' );
         }
     });