Changeset 26204

Timestamp:

11/15/2013 05:34:14 AM (12 years ago)

Author:

nacin

Message:

Fix JSHint errors in post.js.

props atimmer.
fixes #25994.

File:

• trunk/src/wp-admin/js/post.js (modified) (29 diffs)

trunk/src/wp-admin/js/post.js

@@ +1 @@
+/* global postL10n, ajaxurl, wpAjax, setPostThumbnailL10n, postboxes, pagenow, tinymce, alert, deleteUserSetting, getUserSetting, setUserSetting */
+/* global theList:true, theExtraList:true, autosave:true */
+
 var tagBox, commentsBox, editPermalink, makeSlugeditClickable, WPSetThumbnailHTML, WPSetThumbnailID, WPRemoveThumbnail, wptitlehint;
 
@@ -82 +85 @@
 
     flushTags : function(el, a, f) {
+        var tagsval, newtags, text,
+            tags = $('.the-tags', el),
+            newtag = $('input.newtag', el),
+            comma = postL10n.comma;
         a = a || false;
-        var tags = $('.the-tags', el),
-            newtag = $('input.newtag', el),
-            comma = postL10n.comma,
-            newtags, text;
 
         text = a ? $(a).text() : newtag.val();
@@ -109 +112 @@
 
         $.post(ajaxurl, {'action':'get-tagcloud', 'tax':tax}, function(r, stat) {
-            if ( 0 == r || 'success' != stat )
+            if ( 0 === r || 'success' != stat )
                 r = wpAjax.broken;
 
@@ -138 +141 @@
 
         $('input.newtag', ajaxtag).blur(function() {
-            if ( this.value == '' )
+            if ( '' === this.value )
                 $(this).parent().siblings('.taghint').css('visibility', '');
         }).focus(function(){
@@ -207 +210 @@
 
                     theList = theExtraList = null;
-                    $("a[className*=':']").unbind();
+                    $( 'a[className*=\':\']' ).unbind();
 
                     if ( commentsBox.st > commentsBox.total )
@@ -241 +244 @@
 WPRemoveThumbnail = function(nonce){
     $.post(ajaxurl, {
-        action:"set-post-thumbnail", post_id: $('#post_ID').val(), thumbnail_id: -1, _ajax_nonce: nonce, cookie: encodeURIComponent(document.cookie)
+        action: 'set-post-thumbnail', post_id: $( '#post_ID' ).val(), thumbnail_id: -1, _ajax_nonce: nonce, cookie: encodeURIComponent( document.cookie )
     }, function(str){
         if ( str == '0' ) {
@@ -260 +263 @@
         return;
 
-    send['post_id'] = post_id;
+    send.post_id = post_id;
 
     if ( lock )
-        send['lock'] = lock;
+        send.lock = lock;
 
     data['wp-refresh-post-lock'] = send;
@@ -352 +355 @@
 
 jQuery(document).ready( function($) {
-    var stamp, visibility, sticky = '', last = 0, co = $('#content');
+    var stamp, visibility, updateVisibility, updateText,
+        sticky = '', last = 0, co = $('#content');
 
     postboxes.add_postbox_toggles(pagenow);
@@ -407 +411 @@
             $(t).show();
             if ( '#' + taxonomy + '-all' == t )
-                deleteUserSetting(settingName);
+                deleteUserSetting( settingName );
             else
-                setUserSetting(settingName, 'pop');
-            return false;
-        });
-
-        if ( getUserSetting(settingName) )
+                setUserSetting( settingName, 'pop' );
+            return false;
+        });
+
+        if ( getUserSetting( settingName ) )
             $('a[href="#' + taxonomy + '-pop"]', '#' + taxonomy + '-tabs').click();
 
         // Ajax Cat
-        $('#new' + taxonomy).one( 'focus', function() { $(this).val( '' ).removeClass( 'form-input-tip' ) } );
+        $( '#new' + taxonomy ).one( 'focus', function() { $( this ).val( '' ).removeClass( 'form-input-tip' ); } );
 
         $('#new' + taxonomy).keypress( function(event){
@@ -469 +473 @@
     // Custom Fields
     if ( $('#postcustom').length ) {
-        $('#the-list').wpList( { addAfter: function( xml, s ) {
+        $( '#the-list' ).wpList( { addAfter: function() {
             $('table#list-table').show();
         }, addBefore: function( s ) {
@@ -483 +487 @@
         visibility = $('#post-visibility-display').html();
 
-        function updateVisibility() {
+        updateVisibility = function() {
             var pvSelect = $('#post-visibility-select');
             if ( $('input:radio:checked', pvSelect).val() != 'public' ) {
@@ -496 +500 @@
                 $('#password-span').show();
             }
-        }
-
-        function updateText() {
+        };
+
+        updateText = function() {
 
             if ( ! $('#timestampdiv').length )
@@ -537 +541 @@
                         .replace( '%3$s', aa )
                         .replace( '%4$s', hh )
-                        .replace( '%5$s', mn )
-                    + '</b> '
+                        .replace( '%5$s', mn ) +
+                        '</b> '
                 );
             }
@@ -544 +548 @@
             if ( $('input:radio:checked', '#post-visibility-select').val() == 'private' ) {
                 $('#publish').val( postL10n.update );
-                if ( optPublish.length == 0 ) {
+                if ( 0 === optPublish.length ) {
                     postStatus.append('<option value="publish">' + postL10n.privatelyPublished + '</option>');
                 } else {
@@ -575 +579 @@
             }
             return true;
-        }
+        };
 
         $('.edit-visibility', '#visibility').click(function () {
-            if ($('#post-visibility-select').is(":hidden")) {
+            if ( $( '#post-visibility-select' ).is( ':hidden' ) ) {
                 updateVisibility();
                 $('#post-visibility-select').slideDown('fast');
@@ -608 +612 @@
             } // WEAPON LOCKED
 
-            if ( true == $('#sticky').prop('checked') ) {
+            if ( $('#sticky').prop('checked') ) {
                 sticky = 'Sticky';
             } else {
@@ -623 +627 @@
 
         $('#timestampdiv').siblings('a.edit-timestamp').click(function() {
-            if ($('#timestampdiv').is(":hidden")) {
+            if ( $( '#timestampdiv' ).is( ':hidden' ) ) {
                 $('#timestampdiv').slideDown('fast');
                 $('#mm').focus();
@@ -662 +666 @@
 
         $('#post-status-select').siblings('a.edit-post-status').click(function() {
-            if ($('#post-status-select').is(":hidden")) {
+            if ( $( '#post-status-select' ).is( ':hidden' ) ) {
                 $('#post-status-select').slideDown('fast');
                 $(this).hide();
@@ -688 +692 @@
     if ( $('#edit-slug-box').length ) {
         editPermalink = function(post_id) {
-            var i, c = 0, e = $('#editable-post-name'), revert_e = e.html(), real_slug = $('#post_name'), revert_slug = real_slug.val(), b = $('#edit-slug-buttons'), revert_b = b.html(), full = $('#editable-post-name-full').html();
+            var slug_value, i,
+                c = 0,
+                e = $( '#editable-post-name' ),
+                revert_e = e.html(),
+                real_slug = $( '#post_name' ),
+                revert_slug = real_slug.val(),
+                b = $( '#edit-slug-buttons' ),
+                revert_b = b.html(),
+                full = $( '#editable-post-name-full' ).html();
 
             $('#view-post-btn').hide();
@@ -744 +756 @@
                     return false;
                 }
-            }).keyup(function(e) {
+            } ).keyup( function() {
                 real_slug.val(this.value);
             }).focus();
-        }
+        };
 
         makeSlugeditClickable = function() {
@@ -753 +765 @@
                 $('#edit-slug-buttons').children('.edit-slug').click();
             });
-        }
+        };
         makeSlugeditClickable();
     }
@@ -780 +792 @@
         var title = $('#' + id), titleprompt = $('#' + id + '-prompt-text');
 
-        if ( title.val() == '' )
+        if ( '' === title.val() )
             titleprompt.removeClass('screen-reader-text');
 
@@ -789 +801 @@
 
         title.blur(function(){
-            if ( this.value == '' )
+            if ( '' === this.value )
                 titleprompt.removeClass('screen-reader-text');
         }).focus(function(){
@@ -797 +809 @@
             $(this).unbind(e);
         });
-    }
+    };
 
     wptitlehint();
@@ -813 +825 @@
         }
 
-        function endDrag(e) {
+        function endDrag() {
             var height;
 
@@ -860 +872 @@
 
             // resize TinyMCE to match the textarea height when switching Text -> Visual
-            ed.onLoadContent.add( function(ed, o) {
+            ed.onLoadContent.add( function() {
                 var ifr_height, node = document.getElementById('content'),
                     height = node ? parseInt( node.style.height, 10 ) : 0,
@@ -883 +895 @@
 
             // resize the textarea to match TinyMCE's height when switching Visual -> Text
-            ed.onSaveContent.add( function(ed, o) {
+            ed.onSaveContent.add( function() {
                 var height = getHeight();
 
@@ -894 +906 @@
             // save on resizing TinyMCE
             ed.onPostRender.add(function() {
-                $('#content_resize').on('mousedown.wp-mce-resize', function(e){
-                    $(document).on('mouseup.wp-mce-resize', function(e){
+                $( '#content_resize' ).on( 'mousedown.wp-mce-resize', function() {
+                    $( document ).on( 'mouseup.wp-mce-resize', function() {
                         var height;
 
@@ -910 +922 @@
 
         // When changing post formats, change the editor body class
-        $('#post-formats-select input.post-format').on( 'change.set-editor-class', function( event ) {
+        $( '#post-formats-select input.post-format' ).on( 'change.set-editor-class', function() {
             var editor, body, format = this.id;