Changeset 26232

Timestamp:

11/15/2013 11:18:18 PM (11 years ago)

Author:

nacin

Message:

Fix JSHint errors in three files.

props tommcfarlin.
fixes #25942, #25943, #25944.

Location:

trunk/src/wp-admin/js

Files:

• dashboard.js (modified) (9 diffs)
• media-gallery.js (modified) (1 diff)
• theme-preview.js (modified) (3 diffs)

trunk/src/wp-admin/js/dashboard.js

@@ -1 @@
-/* global pagenow */
+/* global pagenow, ajaxurl, postboxes, wpActiveEditor:true */
 var ajaxWidgets, ajaxPopulateWidgets, quickPressLoad;
 
@@ -6 +6 @@
     var welcomePanel = $('#welcome-panel'),
         welcomePanelHide = $('#wp_welcome_panel-hide'),
-        updateWelcomePanel = function( visible ) {
+        updateWelcomePanel = function( visible ) {
             $.post( ajaxurl, {
                 action: 'update-welcome-panel',
@@ -14 +14 @@
         };
 
-    if ( welcomePanel.hasClass('hidden') && welcomePanelHide.prop('checked') )
+    if ( welcomePanel.hasClass('hidden') && welcomePanelHide.prop('checked') ) {
         welcomePanel.removeClass('hidden');
+    }
 
     $('.welcome-panel-close, .welcome-panel-dismiss a', welcomePanel).click( function(e) {
@@ -49 +50 @@
         if ( el ) {
             el = el.toString();
-            if ( $.inArray(el, ajaxWidgets) != -1 )
+            if ( $.inArray(el, ajaxWidgets) !== -1 ) {
                 show(0, el);
+            }
         } else {
             $.each( ajaxWidgets, show );
@@ -91 +93 @@
             var input = $(this), prompt = $('#' + this.id + '-prompt-text');
 
-            if ( '' === this.value )
+            if ( '' === this.value ) {
                 prompt.removeClass('screen-reader-text');
+            }
 
             prompt.click( function() {
@@ -100 +103 @@
 
             input.blur( function() {
-                if ( '' === this.value )
+                if ( '' === this.value ) {
                     prompt.removeClass('screen-reader-text');
+                }
             });
 
@@ -110 +114 @@
 
         $('#quick-press').on( 'click focusin', function() {
-            $(this).addClass("quickpress-open");
-            $("#description-wrap, p.submit").slideDown(200);
+            $(this).addClass('quickpress-open');
+            $('#description-wrap, p.submit').slideDown(200);
             wpActiveEditor = 'content';
         });
@@ -121 +125 @@
         $( this ).fadeOut().closest('.activity-block').find( 'li.hidden' ).fadeIn().removeClass( 'hidden' );
         e.preventDefault();
-    })
+    });
 
     // Dashboard columns
-    jQuery(document).ready(function ($) {
+    jQuery(document).ready(function () {
         // Update main column count on load
         updateColumnCount();
@@ -135 +139 @@
     function updateColumnCount() {
         var cols = 1,
-            windowWidth = parseInt(jQuery(window).width());
-        if (799 < windowWidth && 1299 > windowWidth)
+            windowWidth = parseInt(jQuery(window).width(), 10);
+
+        if (799 < windowWidth && 1299 > windowWidth) {
             cols = 2;
-        if (1300 < windowWidth && 1799 > windowWidth)
+        }
+
+        if (1300 < windowWidth && 1799 > windowWidth) {
             cols = 3;
-        if (1800 < windowWidth)
+        }
+
+        if (1800 < windowWidth) {
             cols = 4;
+        }
         jQuery('.metabox-holder').attr('class', jQuery('.metabox-holder').attr('class').replace(/columns-\d+/, 'columns-' + cols));
     }

trunk/src/wp-admin/js/media-gallery.js

@@ +1 @@
+/* global ajaxurl */
 jQuery(function($){
     $( 'body' ).bind( 'click.wp-gallery', function(e){

trunk/src/wp-admin/js/theme-preview.js

@@ -1 @@
-
+/* global tb_click */
 var thickDims, tbWidth, tbHeight;
 jQuery(document).ready(function($) {
@@ -13 +13 @@
             $('#TB_iframeContent').width(w).height(h - 27);
             tbWindow.css({'margin-left': '-' + parseInt((w / 2),10) + 'px'});
-            if ( typeof document.body.style.maxWidth != 'undefined' )
+            if ( typeof document.body.style.maxWidth !== 'undefined' ) {
                 tbWindow.css({'top':'30px','margin-top':'0'});
+            }
         }
     };
 
     thickDims();
-    $(window).resize( function() { thickDims() } );
+    $(window).resize( function() { thickDims(); } );
 
     $('a.thickbox-preview').click( function() {
@@ -26 +27 @@
         var alink = $(this).parents('.available-theme').find('.activatelink'), link = '', href = $(this).attr('href'), url, text;
 
-        if ( tbWidth = href.match(/&tbWidth=[0-9]+/) )
+        if ( tbWidth = href.match(/&tbWidth=[0-9]+/) ) {
             tbWidth = parseInt(tbWidth[0].replace(/[^0-9]+/g, ''), 10);
-        else
+        } else {
             tbWidth = $(window).width() - 90;
+        }
 
-        if ( tbHeight = href.match(/&tbHeight=[0-9]+/) )
+        if ( tbHeight = href.match(/&tbHeight=[0-9]+/) ) {
             tbHeight = parseInt(tbHeight[0].replace(/[^0-9]+/g, ''), 10);
-        else
+        } else {
             tbHeight = $(window).height() - 60;
+        }
 
         if ( alink.length ) {