Changeset 26252

Timestamp:

11/18/2013 08:44:34 PM (11 years ago)

Author:

wonderboymusic

Message:

For unit tests that call wpmu_create_blog(), Blog factory, or installation code that attempts to clear transients: suppress database errors on setUp and restore on tearDown.

There are a few places in core that were preventing this from working by explicity setting $wpdb->suppress_errors to false. Instead, they should inherit the value that existed before errors were suppressed.

This allows Multisite unit tests to run without explosive database errors, and allows $wpdb->suppress_errors to be overridden all the way down the chain.

Fixes #26102.

Location:

trunk

Files:

• src/wp-admin/includes/upgrade.php (modified) (1 diff)
• src/wp-includes/ms-functions.php (modified) (2 diffs)
• tests/phpunit/includes/factory.php (modified) (1 diff)
• tests/phpunit/tests/ms.php (modified) (3 diffs)
• tests/phpunit/tests/option/blogOption.php (modified) (1 diff)

trunk/src/wp-admin/includes/upgrade.php

@@ -1554 +1554 @@
 
         // Fetch the table column structure from the database
-        $wpdb->suppress_errors();
+        $suppress = $wpdb->suppress_errors();
         $tablefields = $wpdb->get_results("DESCRIBE {$table};");
-        $wpdb->suppress_errors( false );
+        $wpdb->suppress_errors( $suppress );
 
         if ( ! $tablefields )

trunk/src/wp-includes/ms-functions.php

@@ -1130 +1130 @@
     require_once( ABSPATH . 'wp-admin/includes/upgrade.php' );
 
-    $wpdb->suppress_errors();
+    $suppress = $wpdb->suppress_errors();
     if ( $wpdb->get_results( "DESCRIBE {$wpdb->posts}" ) )
         die( '<h1>' . __( 'Already Installed' ) . '</h1><p>' . __( 'You appear to have already installed WordPress. To reinstall please clear your old database tables first.' ) . '</p></body></html>' );
-    $wpdb->suppress_errors( false );
+    $wpdb->suppress_errors( $suppress );
 
     $url = get_blogaddress_by_id( $blog_id );
@@ -1180 +1180 @@
     require_once( ABSPATH . 'wp-admin/includes/upgrade.php' );
 
-    $wpdb->suppress_errors();
+    $suppress = $wpdb->suppress_errors();
 
     wp_install_defaults($user_id);
 
-    $wpdb->suppress_errors( false );
+    $wpdb->suppress_errors( $suppress );
 }
 

trunk/tests/phpunit/includes/factory.php

@@ -160 +160 @@
 
     function create_object( $args ) {
+        global $wpdb;
         $meta = isset( $args['meta'] ) ? $args['meta'] : array();
         $user_id = isset( $args['user_id'] ) ? $args['user_id'] : get_current_user_id();
-        return wpmu_create_blog( $args['domain'], $args['path'], $args['title'], $user_id, $meta, $args['site_id'] );
+        // temp tables will trigger db errors when we attempt to reference them as new temp tables
+        $suppress = $wpdb->suppress_errors();
+        $blog = wpmu_create_blog( $args['domain'], $args['path'], $args['title'], $user_id, $meta, $args['site_id'] );
+        $wpdb->suppress_errors( $suppress );
+        return $blog;
     }
 

trunk/tests/phpunit/tests/ms.php

@@ -10 +10 @@
 class Tests_MS extends WP_UnitTestCase {
     protected $plugin_hook_count = 0;
+    protected $suppress = false;
 
     function setUp() {
+        global $wpdb;
         parent::setUp();
+        $this->suppress = $wpdb->suppress_errors();
 
         $_SERVER['REMOTE_ADDR'] = '';
+    }
+
+    function tearDown() {
+        global $wpdb;
+        parent::tearDown();
+        $wpdb->suppress_errors( $this->suppress );
     }
 
@@ -106 +115 @@
 
             foreach ( $wpdb->tables( 'blog', false ) as $table ) {
-                $wpdb->suppress_errors();
+                $suppress = $wpdb->suppress_errors();
                 $table_fields = $wpdb->get_results( "DESCRIBE $prefix$table;" );
-                $wpdb->suppress_errors( false );
+                $wpdb->suppress_errors( $suppress );
                 $this->assertNotEmpty( $table_fields );
                 $result = $wpdb->get_results( "SELECT * FROM $prefix$table LIMIT 1" );
@@ -140 +149 @@
             $prefix = $wpdb->get_blog_prefix( $blog_id );
             foreach ( $wpdb->tables( 'blog', false ) as $table ) {
-                $wpdb->suppress_errors();
+                $suppress = $wpdb->suppress_errors();
                 $table_fields = $wpdb->get_results( "DESCRIBE $prefix$table;" );
-                $wpdb->suppress_errors( false );
+                $wpdb->suppress_errors( $suppress );
                 if ( $drop_tables )
                     $this->assertEmpty( $table_fields );

trunk/tests/phpunit/tests/option/blogOption.php

@@ -6 +6 @@
  */
 class Tests_Option_BlogOption extends WP_UnitTestCase {
+    protected $suppress = false; 
+
     function setUp() {
+        global $wpdb;
         parent::setUp();
+        $this->suppress = $wpdb->suppress_errors();
 
         $_SERVER['REMOTE_ADDR'] = null;
+    }
+
+    function tearDown() {
+        global $wpdb;
+        parent::tearDown();
+        $wpdb->suppress_errors( $this->suppress );
     }