Changeset 26270 for trunk/src/wp-content/themes/twentyfourteen/inc/featured-content.php

Timestamp:

11/19/2013 03:26:56 PM (11 years ago)

Author:

lancewillett

Message:

Twenty Fourteen: avoid premature creation of tags when using the tag suggestion for Featured Content. Props obenland, fixes #26080.

File:

• trunk/src/wp-content/themes/twentyfourteen/inc/featured-content.php (modified) (1 diff)

trunk/src/wp-content/themes/twentyfourteen/inc/featured-content.php

@@ -449 +449 @@
             $output['tag-id'] = 0;
         } else {
-            $new_tag = wp_create_tag( $input['tag-name'] );
-            if ( ! is_wp_error( $new_tag ) && isset( $new_tag['term_id'] ) ) {
-                $output['tag-id'] = $new_tag['term_id'];
+            $term = get_term_by( 'name', $input['tag-name'], 'post_tag' );
+
+            if ( $term ) {
+                $output['tag-id'] = $term->term_id;
             } else {
-                $term = get_term_by( 'name', $input['tag-name'], 'post_tag' );
-                $output['tag-id'] = $term ? $term->term_id : 0;
+                $new_tag = wp_create_tag( $input['tag-name'] );
+
+                if ( ! is_wp_error( $new_tag ) && isset( $new_tag['term_id'] ) ) {
+                    $output['tag-id'] = $new_tag['term_id'];
+                }
             }
+
             $output['tag-name'] = $input['tag-name'];
         }