Changeset 26304 for trunk/src/wp-includes/option.php

Timestamp:

11/21/2013 07:06:26 PM (11 years ago)

Author:

wonderboymusic

Message:

Prefix the notoptions cache key in the multisite site-options group with $wpdb->siteid to avoid collisions and race conditions when using a fancy multi-network setup. Adds unit test.

Fixes #25883.

File:

• trunk/src/wp-includes/option.php (modified) (6 diffs)

trunk/src/wp-includes/option.php

@@ -758 +758 @@
 
     // prevent non-existent options from triggering multiple queries
-    $notoptions = wp_cache_get( 'notoptions', 'site-options' );
+    $notoptions_key = "{$wpdb->siteid}:notoptions";
+    $notoptions = wp_cache_get( $notoptions_key, 'site-options' );
     if ( isset( $notoptions[$option] ) )
         return apply_filters( 'default_site_option_' . $option, $default );
@@ -780 +781 @@
             } else {
                 $notoptions[$option] = true;
-                wp_cache_set( 'notoptions', $notoptions, 'site-options' );
+                wp_cache_set( $notoptions_key, $notoptions, 'site-options' );
                 $value = apply_filters( 'default_site_option_' . $option, $default );
             }
@@ -813 +814 @@
 
     $value = apply_filters( 'pre_add_site_option_' . $option, $value );
+    $notoptions_key = "{$wpdb->siteid}:notoptions";
 
     if ( !is_multisite() ) {
@@ -820 +822 @@
 
         // Make sure the option doesn't already exist. We can check the 'notoptions' cache before we ask for a db query
-        $notoptions = wp_cache_get( 'notoptions', 'site-options' );
+        $notoptions = wp_cache_get( $notoptions_key, 'site-options' );
         if ( ! is_array( $notoptions ) || ! isset( $notoptions[$option] ) )
             if ( false !== get_site_option( $option ) )
@@ -836 +838 @@
 
         // This option exists now
-        $notoptions = wp_cache_get( 'notoptions', 'site-options' ); // yes, again... we need it to be fresh
+        $notoptions = wp_cache_get( $notoptions_key, 'site-options' ); // yes, again... we need it to be fresh
         if ( is_array( $notoptions ) && isset( $notoptions[$option] ) ) {
             unset( $notoptions[$option] );
-            wp_cache_set( 'notoptions', $notoptions, 'site-options' );
+            wp_cache_set( $notoptions_key, $notoptions, 'site-options' );
         }
     }
@@ -923 +925 @@
         return add_site_option( $option, $value );
 
-    $notoptions = wp_cache_get( 'notoptions', 'site-options' );
+    $notoptions_key = "{$wpdb->siteid}:notoptions";
+    $notoptions = wp_cache_get( $notoptions_key, 'site-options' );
     if ( is_array( $notoptions ) && isset( $notoptions[$option] ) ) {
         unset( $notoptions[$option] );
-        wp_cache_set( 'notoptions', $notoptions, 'site-options' );
+        wp_cache_set( $notoptions_key, $notoptions, 'site-options' );
     }