Changeset 26307 for trunk/src/wp-includes/meta.php

Timestamp:

11/21/2013 07:30:35 PM (12 years ago)

Author:

wonderboymusic

Message:

In update_meta_cache(), ensure that meta is always stored in the same order. Removes an unnecessary $wpdb->prepare statement. Adds unit test.

Props mattheu.
Fixes #25511.

File:

• trunk/src/wp-includes/meta.php (modified) (1 diff)

trunk/src/wp-includes/meta.php

@@ -559 +559 @@
 
     // Get meta info
-    $id_list = join(',', $ids);
-    $meta_list = $wpdb->get_results( $wpdb->prepare("SELECT $column, meta_key, meta_value FROM $table WHERE $column IN ($id_list)",
-        $meta_type), ARRAY_A );
+    $id_list = join( ',', $ids );
+    $id_column = 'user' == $meta_type ? 'umeta_id' : 'meta_id';
+    $meta_list = $wpdb->get_results( "SELECT $column, meta_key, meta_value FROM $table WHERE $column IN ($id_list) ORDER BY $id_column ASC", ARRAY_A );
 
     if ( !empty($meta_list) ) {