Changeset 26328

Timestamp:

11/22/2013 04:24:25 PM (11 years ago)

Author:

wonderboymusic

Message:

Add unit tests for links_add_target(). Alter the patterns in links_add_target() and _links_add_target() slightly based on learnings after running tests.

Props mdbitz.
Fixes #26164.

Location:

trunk

Files:

• src/wp-includes/formatting.php (modified) (2 diffs)
• tests/phpunit/tests/formatting/LinksAddTarget.php (added)

trunk/src/wp-includes/formatting.php

@@ -3244 +3244 @@
     $_links_add_target = $target;
     $tags = implode('|', (array)$tags);
-    return preg_replace_callback( "!<($tags)(.+?)>!i", '_links_add_target', $content );
+    return preg_replace_callback( "!<($tags)([^>]*)>!i", '_links_add_target', $content );
 }
 
@@ -3259 +3259 @@
     global $_links_add_target;
     $tag = $m[1];
-    $link = preg_replace('|(target=([\'"])(.*?)\2)|i', '', $m[2]);
+    $link = preg_replace('|( target=([\'"])(.*?)\2)|i', '', $m[2]);
     return '<' . $tag . $link . ' target="' . esc_attr( $_links_add_target ) . '">';
 }