Changeset 26426 for trunk/src/wp-admin/includes/widgets.php

Timestamp:

11/27/2013 01:29:49 AM (13 years ago)

Author:

azaozz

Message:

Widgets: drop onto closed sidebars.

• Make dropping a widget easier by preventing the source sidebar from resizing while the widget is being dragged.
• Move widgets dropped on closed sidebars to the top. UI Sortable places them randomly near the bottom.
• Fix possible regression in wp_list_widget_controls(), add an optional argument to output the sidebar name inside the sortable container.
• Updated styles for sidebar description and widget-hover class.

Part props shaunandrews, fixes #25952.

File:

• trunk/src/wp-admin/includes/widgets.php (modified) (1 diff)

trunk/src/wp-admin/includes/widgets.php

@@ -64 +64 @@
  *
  * @param string $sidebar id slug of the sidebar
- */
-function wp_list_widget_controls( $sidebar ) {
+ * @param string optional $sidebar_name Include the HTML for the sidebar name
+ */
+function wp_list_widget_controls( $sidebar, $sidebar_name = '' ) {
         add_filter( 'dynamic_sidebar_params', 'wp_list_widget_controls_dynamic_sidebar' );
 
         $description = wp_sidebar_description( $sidebar );
 
-        if ( !empty( $description ) ) {
-                echo "<div class='sidebar-description'>\n";
-                echo "\t<p class='description'>$description</p>";
-                echo "</div>\n";
-        }
-
-        echo "<div id='$sidebar' class='widgets-sortables'>\n";
+        echo '<div id="' . esc_attr( $sidebar ) . '" class="widgets-sortables">';
+
+        if ( $sidebar_name ) {
+                ?>
+                <div class="sidebar-name">
+                        <div class="sidebar-name-arrow"><br /></div>
+                        <h3><?php echo esc_html( $sidebar_name ); ?> <span class="spinner"></span></h3>
+                </div>
+                <?php
+        }
+
+        echo '<div class="sidebar-description">';
+
+        if ( ! empty( $description ) ) {
+                echo '<p class="description">' . $description . '</p>';
+        }
+
+        echo '</div>';
+
         dynamic_sidebar( $sidebar );
-        echo "</div>\n";
+
+        echo '</div>';
 }