Changeset 26487

Timestamp:

11/30/2013 10:38:46 PM (11 years ago)

Author:

SergeyBiryukov

Message:

Escape smiley URL in translate_smiley().

props simonwheatley.
fixes #25529.

File:

• trunk/src/wp-includes/formatting.php (modified) (2 diffs)

trunk/src/wp-includes/formatting.php

@@ -1863 +1863 @@
     $smiley = trim( reset( $matches ) );
     $img = $wpsmiliestrans[ $smiley ];
-    $smiley_masked = esc_attr( $smiley );
 
     /**
@@ -1876 +1875 @@
     $src_url = apply_filters( 'smilies_src', includes_url( "images/smilies/$img" ), $img, site_url() );
 
-    return " <img src='$src_url' alt='$smiley_masked' class='wp-smiley' /> ";
+    return sprintf( ' <img src="%s" alt="%s" class="wp-smiley" /> ', esc_url( $src_url ), esc_attr( $smiley ) );
 }