Context Navigation

term.php

Timestamp:

12/01/2013 11:59:13 PM (13 years ago)

Author:

wonderboymusic

Message:

Fix lingering reference problem in wp_get_object_terms() by not setting the foreach'd vars to a reference. Adds unit test.

Props stephenharris.
Fixes #26339.

File:

-              r26187
+              r26510
         function setUp() {
                 parent::setUp();
                 _clean_term_filters();
                 // insert one term into every post taxonomy
 …
                 // clean up
                 $this->assertTrue( wp_delete_term($t['term_id'], $this->taxonomy) );
+        }
+        function test_get_object_terms() {
+                $post_id = $this->factory->post->create();
+                $terms_1 = array('foo', 'bar', 'baz');
+                wp_set_object_terms( $post_id, $terms_1, $this->taxonomy );
+                add_filter( 'wp_get_object_terms', array( $this, 'filter_get_object_terms' ) );
+                $terms = wp_get_object_terms( $post_id, $this->taxonomy );
+                remove_filter( 'wp_get_object_terms', array( $this, 'filter_get_object_terms' ) );
+                foreach ( $terms as $term ) {
+                        $this->assertInternalType( 'object', $term );
+                }
+        }
+        function filter_get_object_terms( $terms ) {
+                // var_dump reveals an array of objects
+                $term_ids = wp_list_pluck( $terms, 'term_id' );
+                // last term is now an integer
+                return $terms;
+        }

Note: See TracChangeset for help on using the changeset viewer.