Changeset 26543

Timestamp:

12/02/2013 10:58:40 PM (7 years ago)

Author:

nacin

Message:

Return false from wp_delete_post() and wp_delete_attachment() if the DELETE is unsuccessful.

This prevents attachments from being deleted off disk when a DB is locked and the delete is otherwise unsuccessful.

fixes #25107.

File:

• trunk/src/wp-includes/post.php (modified) (2 diffs)

trunk/src/wp-includes/post.php

@@ -2336 +2336 @@
 
     do_action( 'delete_post', $postid );
-    $wpdb->delete( $wpdb->posts, array( 'ID' => $postid ) );
+    $result = $wpdb->delete( $wpdb->posts, array( 'ID' => $postid ) );
+    if ( ! $result ) {
+        return false;
+    }
     do_action( 'deleted_post', $postid );
 
@@ -4182 +4185 @@
 
     do_action( 'delete_post', $post_id );
-    $wpdb->delete( $wpdb->posts, array( 'ID' => $post_id ) );
+    $result = $wpdb->delete( $wpdb->posts, array( 'ID' => $post_id ) );
+    if ( ! $result ) {
+        return false;
+    }
     do_action( 'deleted_post', $post_id );