Changeset 26560

Timestamp:

12/03/2013 05:27:57 PM (11 years ago)

Author:

lancewillett

Message:

Twenty Fourteen: code cleanup, props kovshenin. See #25946.

• Filtering twentyfourteen_has_featured_posts() false suggests the filter expects a boolean value, but we expect an array. Use an existing function instead.
• In both style.css and ie.css use Genericons, so let's not forget to declare the dependancy.
• Make sure Lato font is enqueued in admin_print_scripts.

File:

• trunk/src/wp-content/themes/twentyfourteen/functions.php (modified) (3 diffs)

trunk/src/wp-content/themes/twentyfourteen/functions.php

@@ -159 +159 @@
 function twentyfourteen_has_featured_posts() {
     /** This filter is documented in functions.php */
-    return ! is_paged() && (bool) apply_filters( 'twentyfourteen_get_featured_posts', false );
+    return ! is_paged() && (bool) twentyfourteen_get_featured_posts();
 }
 
@@ -238 +238 @@
 
     // Load our main stylesheet.
-    wp_enqueue_style( 'twentyfourteen-style', get_stylesheet_uri() );
+    wp_enqueue_style( 'twentyfourteen-style', get_stylesheet_uri(), array( 'twentyfourteen-genericons' ) );
 
     // Load the Internet Explorer specific stylesheet.
-    wp_enqueue_style( 'twentyfourteen-ie', get_template_directory_uri() . '/css/ie.css', array( 'twentyfourteen-style' ), '20131110' );
+    wp_enqueue_style( 'twentyfourteen-ie', get_template_directory_uri() . '/css/ie.css', array( 'twentyfourteen-style', 'twentyfourteen-genericons' ), '20131110' );
     wp_style_add_data( 'twentyfourteen-ie', 'conditional', 'lt IE 9' );
 
@@ -276 +276 @@
  */
 function twentyfourteen_admin_fonts() {
-    wp_enqueue_style( 'twentyfourteen-lato' );
+    wp_enqueue_style( 'twentyfourteen-lato', twentyfourteen_font_url(), array(), null );
 }
 add_action( 'admin_print_scripts-appearance_page_custom-header', 'twentyfourteen_admin_fonts' );