Changeset 26577

Timestamp:

12/03/2013 06:46:02 PM (11 years ago)

Author:

lancewillett

Message:

Twenty Fourteen: remove transient usage in Ephemera widget to fix caching issues. Props obenland, closes #26210 and #26335.

File:

• trunk/src/wp-content/themes/twentyfourteen/inc/widgets.php (modified) (4 diffs)

trunk/src/wp-content/themes/twentyfourteen/inc/widgets.php

@@ -76 +76 @@
      */
     public function widget( $args, $instance ) {
-        // If called directly, assign an unique index for caching.
-        if ( -1 == $this->number ) {
-            static $num = -1;
-            $this->_set( --$num );
-        }
-
-        $content = get_transient( $this->id );
-
-        if ( false !== $content ) {
-            echo $content;
-            return;
-        }
-
-        ob_start();
-        extract( $args, EXTR_SKIP );
-
         $format = $instance['format'];
         $number = empty( $instance['number'] ) ? 2 : absint( $instance['number'] );
@@ -116 +100 @@
             $GLOBALS['content_width'] = 306;
 
-            echo $before_widget;
+            echo $args['before_widget'];
             ?>
             <h1 class="widget-title <?php echo esc_attr( $format ); ?>">
@@ -210 +194 @@
             <?php
 
-            echo $after_widget;
+            echo $args['after_widget'];
 
             // Reset the post globals as this query will have stomped on it.
@@ -218 +202 @@
 
         endif; // End check for ephemeral posts.
-
-        set_transient( $this->id, ob_get_flush() );
     }