Changeset 26664 for trunk/src/wp-admin/menu-header.php

Timestamp:

12/05/2013 06:37:20 AM (12 years ago)

Author:

nacin

Message:

Allow for Dashicons and base64-encoded data:image/svg+xml URIs when specifying menu icons.

Both of these icons can be colored to match the color scheme, including hover states.
Both are accepted for register_post_type()'s menu_icon argument, and also add_menu_page()'s $icon_url argument.

To use a Dashicon, pass the name of the helper class, e.g. 'dashicons-piechart'.
To use an SVG, pass a valid data URI string starting with 'data:image/svg+xml;base64,'.

props helen.
fixes #25147.

File:

• trunk/src/wp-admin/menu-header.php (modified) (3 diffs)

trunk/src/wp-admin/menu-header.php

@@ -68 +68 @@
         $class = $class ? ' class="' . join( ' ', $class ) . '"' : '';
         $id = ! empty( $item[5] ) ? ' id="' . preg_replace( '|[^a-zA-Z0-9_:.]|', '-', $item[5] ) . '"' : '';
-        $img = '';
+        $img = $img_style = $img_class = '';
+
         // if the string 'none' (previously 'div') is passed instead of an URL, don't output the default menu image
         // so an icon can be added to div.wp-menu-image as background with CSS.
-        if ( ! empty( $item[6] ) )
-            $img = ( 'none' === $item[6] || 'div' === $item[6] ) ? '<br />' : '<img src="' . $item[6] . '" alt="" />';
+        // Dashicons and base64-encoded data:image/svg_xml URIs are also handled as special cases.
+        if ( ! empty( $item[6] ) ) {
+            $img = '<img src="' . $item[6] . '" alt="" />';
+
+            if ( 'none' === $item[6] || 'div' === $item[6] ) {
+                $img = '<br />';
+            } elseif ( 0 === strpos( $item[6], 'data:image/svg+xml;base64,' ) ) {
+                $img = '<br />';
+                $img_style = ' style="background-image:url(\'' . esc_attr( $item[6] ) . '\')"';
+            } elseif ( 0 === strpos( $item[6], 'dashicons-' ) ) {
+                $img = '<br />';
+                $img_class = ' dashicons ' . sanitize_html_class( $item[6] );
+            }
+        }
         $arrow = '<div class="wp-menu-arrow"><div></div></div>';
 
@@ -89 +102 @@
             if ( ! empty( $menu_hook ) || ( ( 'index.php' != $submenu_items[0][2] ) && file_exists( WP_PLUGIN_DIR . "/$menu_file" ) && ! file_exists( ABSPATH . "/wp-admin/$menu_file" ) ) ) {
                 $admin_is_parent = true;
-                echo "<a href='admin.php?page={$submenu_items[0][2]}'$class $aria_attributes>$arrow<div class='wp-menu-image'>$img</div><div class='wp-menu-name'>$title</div></a>";
+                echo "<a href='admin.php?page={$submenu_items[0][2]}'$class $aria_attributes>$arrow<div class='wp-menu-image$img_class'$img_style>$img</div><div class='wp-menu-name'>$title</div></a>";
             } else {
-                echo "\n\t<a href='{$submenu_items[0][2]}'$class $aria_attributes>$arrow<div class='wp-menu-image'>$img</div><div class='wp-menu-name'>$title</div></a>";
+                echo "\n\t<a href='{$submenu_items[0][2]}'$class $aria_attributes>$arrow<div class='wp-menu-image$img_class'$img_style>$img</div><div class='wp-menu-name'>$title</div></a>";
             }
         } elseif ( ! empty( $item[2] ) && current_user_can( $item[1] ) ) {
@@ -100 +113 @@
             if ( ! empty( $menu_hook ) || ( ( 'index.php' != $item[2] ) && file_exists( WP_PLUGIN_DIR . "/$menu_file" ) && ! file_exists( ABSPATH . "/wp-admin/$menu_file" ) ) ) {
                 $admin_is_parent = true;
-                echo "\n\t<a href='admin.php?page={$item[2]}'$class $aria_attributes>$arrow<div class='wp-menu-image'>$img</div><div class='wp-menu-name'>{$item[0]}</div></a>";
+                echo "\n\t<a href='admin.php?page={$item[2]}'$class $aria_attributes>$arrow<div class='wp-menu-image$img_class'$img_style>$img</div><div class='wp-menu-name'>{$item[0]}</div></a>";
             } else {
-                echo "\n\t<a href='{$item[2]}'$class $aria_attributes>$arrow<div class='wp-menu-image'>$img</div><div class='wp-menu-name'>{$item[0]}</div></a>";
+                echo "\n\t<a href='{$item[2]}'$class $aria_attributes>$arrow<div class='wp-menu-image$img_class'$img_style>$img</div><div class='wp-menu-name'>{$item[0]}</div></a>";
             }
         }