Changeset 27012 for trunk/src/wp-admin/themes.php

Timestamp:

01/22/2014 08:59:29 PM (11 years ago)

Author:

nacin

Message:

Themes screen: Add aria-describedby attributes to provide better information to screen readers.

props joedolson for initial patch.
fixes #26602 for trunk.

File:

• trunk/src/wp-admin/themes.php (modified) (3 diffs)

trunk/src/wp-admin/themes.php

@@ -192 +192 @@
  */
 
-foreach ( $themes as $theme ) : ?>
-<div class="theme<?php if ( $theme['active'] ) echo ' active'; ?>" tabindex="0">
+foreach ( $themes as $theme ) :
+    $aria_action = esc_attr( $theme['id'] . '-action' );
+    $aria_name   = esc_attr( $theme['id'] . '-name' );
+    ?>
+<div class="theme<?php if ( $theme['active'] ) echo ' active'; ?>" tabindex="0" aria-describedby="<?php echo $aria_action . ' ' . $aria_name; ?>">
     <?php if ( ! empty( $theme['screenshot'][0] ) ) { ?>
         <div class="theme-screenshot">
@@ -201 +204 @@
         <div class="theme-screenshot blank"></div>
     <?php } ?>
-    <span class="more-details"><?php _e( 'Theme Details' ); ?></span>
+    <span class="more-details" id="<?php echo $aria_action; ?>"><?php _e( 'Theme Details' ); ?></span>
     <div class="theme-author"><?php printf( __( 'By %s' ), $theme['author'] ); ?></div>
 
     <?php if ( $theme['active'] ) { ?>
-        <h3 class="theme-name"><span><?php _ex( 'Active:', 'theme' ); ?></span> <?php echo $theme['name']; ?></h3>
+        <h3 class="theme-name" id="<?php echo $aria_name; ?>"><span><?php _ex( 'Active:', 'theme' ); ?></span> <?php echo $theme['name']; ?></h3>
     <?php } else { ?>
-        <h3 class="theme-name"><?php echo $theme['name']; ?></h3>
+        <h3 class="theme-name" id="<?php echo $aria_name; ?>"><?php echo $theme['name']; ?></h3>
     <?php } ?>
 
@@ -278 +281 @@
         <div class="theme-screenshot blank"></div>
     <# } #>
-    <span class="more-details"><?php _e( 'Theme Details' ); ?></span>
+    <span class="more-details" id="{{ data.id }}-action"><?php _e( 'Theme Details' ); ?></span>
     <div class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.author }}}' ); ?></div>
 
     <# if ( data.active ) { #>
-        <h3 class="theme-name"><span><?php _ex( 'Active:', 'theme' ); ?></span> {{{ data.name }}}</h3>
+        <h3 class="theme-name" id="{{ data.id }}-name"><span><?php _ex( 'Active:', 'theme' ); ?></span> {{{ data.name }}}</h3>
     <# } else { #>
-        <h3 class="theme-name">{{{ data.name }}}</h3>
+        <h3 class="theme-name" id="{{ data.id }}-name">{{{ data.name }}}</h3>
     <# } #>