Changeset 27040 for trunk/tests/phpunit/tests/formatting/balanceTags.php

Timestamp:

01/27/2014 02:57:51 AM (11 years ago)

Author:

nacin

Message:

Remove duplicated and superceded balance tags unit tests.

props coffee2code.
fixes #26222.

File:

• trunk/tests/phpunit/tests/formatting/balanceTags.php (modified) (5 diffs)

trunk/tests/phpunit/tests/formatting/balanceTags.php

@@ -8 +8 @@
     function nestable_tags() {
         return array(
-            array( 'blockquote', 'div', 'object', 'q', 'span' )
+            array( 'blockquote' ), array( 'div' ), array( 'object' ), array( 'q' ), array( 'span' ),
         );
     }
@@ -21 +21 @@
     }
 
-    // These are single/self-closing tags that WP has traditionally recognized.
-    function basic_single_tags() {
-        return array(
-            array( 'br' ), array( 'hr' ), array( 'img' ), array( 'input' )
-        );
-    }
-
-    /**
-     * These are single tags WP has traditionally properly handled
-     * This test can be removed if #1597 is fixed and the next test passes, as
-     * it supercedes this test.
-     *
-     * @dataProvider basic_single_tags
-     */
-    function test_selfcloses_unclosed_basic_known_single_tags( $tag ) {
-        $this->assertEquals( "<$tag />", balanceTags( "<$tag>", true ) );
-    }
-
     /**
      * If a recognized valid single tag appears unclosed, it should get self-closed
@@ -47 +29 @@
     function test_selfcloses_unclosed_known_single_tags( $tag ) {
         $this->assertEquals( "<$tag />", balanceTags( "<$tag>", true ) );
-    }
-
-    /**
-     * These are single tags WP has traditionally properly handled
-     * This test can be removed if #1597 is fixed and the next test passes, as
-     * it supercedes this test.
-     *
-     * @dataProvider basic_single_tags
-     */
-    function test_selfcloses_basic_known_single_tags_having_closing_tag( $tag ) {
-        $this->assertEquals( "<$tag />", balanceTags( "<$tag></$tag>", true ) );
     }
 
@@ -122 +93 @@
     }
 
-    function test_balances_nestable_tags() {
-        $inputs = array(
-            '<q>Test<q>Test</q>',
-            '<div><div>Test',
-            '<div>Test</div></div>',
-        );
-        $expected = array(
-            '<q>Test<q>Test</q></q>',
-            '<div><div>Test</div></div>',
-            '<div>Test</div>',
+    /**
+     * @dataProvider nestable_tags
+     */
+    function test_balances_nestable_tags( $tag ) {
+        $inputs = array(
+            "<$tag>Test<$tag>Test</$tag>",
+            "<$tag><$tag>Test",
+            "<$tag>Test</$tag></$tag>",
+        );
+        $expected = array(
+            "<$tag>Test<$tag>Test</$tag></$tag>",
+            "<$tag><$tag>Test</$tag></$tag>",
+            "<$tag>Test</$tag>",
         );
 
@@ -157 +131 @@
      */
     function test_allows_immediately_nested_object_tags() {
-
         $object = '<object id="obj1"><param name="param1"/><object id="obj2"><param name="param2"/></object></object>';
         $this->assertEquals( $object, balanceTags( $object, true ) );