Changeset 27102 for trunk/src/wp-includes/taxonomy.php

Timestamp:

02/06/2014 01:58:01 AM (11 years ago)

Author:

wonderboymusic

Message:

Regenerate the term hierarchy cache ({taxonomy}_children) when it is out of sync with the passed taxonomy's last_changed value.

Introduces taxonomy_hierarchy_is_fresh(), which is only called in _get_term_hierarchy(). The taxonomy's last_changed value is checked against the value of wp_cache_get( 'hierarchy_last_changed', $taxonomy ).

Adds a unit test - Tests_Term:test_hierachy_invalidation().

See [27101], which makes this type of cache invalidation possible.
Fixes #14485.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (3 diffs)

trunk/src/wp-includes/taxonomy.php

@@ -2949 +2949 @@
     if ( !is_taxonomy_hierarchical($taxonomy) )
         return array();
-    $children = get_option("{$taxonomy}_children");
+    $children = false;
+    if ( taxonomy_hierarchy_is_fresh( $taxonomy ) ) {
+        $children = get_option("{$taxonomy}_children");
+    }
 
     if ( is_array($children) )
@@ -3522 +3525 @@
  * Determine if a post's cache for the passed taxonomy
  *  is in sync.
+ * 
  * @since 3.9.0
  *
@@ -3537 +3541 @@
     return true;
 }
+
+/**
+ * Determine if a hierarchy's cache for the passed taxonomy
+ *  is in sync.
+ *
+ * @since 3.9.0
+ *
+ * @param int $id
+ * @param string $taxonomy
+ * @return boolean
+ */
+function taxonomy_hierarchy_is_fresh( $taxonomy ) {
+    $last_changed = get_taxonomy_last_changed( $taxonomy );
+    $hierarchy_last_changed = wp_cache_get( 'hierarchy_last_changed', $taxonomy );
+    if ( ! $hierarchy_last_changed || $last_changed !== $hierarchy_last_changed ) {
+        wp_cache_set( 'hierarchy_last_changed', $last_changed, $taxonomy );
+        return false;
+    }
+    return true;
+}