Changeset 27127

Timestamp:

02/07/2014 10:40:32 PM (11 years ago)

Author:

wonderboymusic

Message:

Introduce maybe_regenerate_attachment_metadata( $attachment ). On the Edit Media screen, call it for Audio and Video files.

The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.

This is the minimum viable product for #26825, but leaving the ticket open unless this function needs to be called in other places.

See #26825.

Location:

trunk/src

Files:

• wp-admin/includes/media.php (modified) (1 diff)
• wp-includes/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -2637 +2637 @@
     elseif ( $attachment_id && 0 === strpos( $post->post_mime_type, 'audio/' ) ):
 
+        maybe_regenerate_attachment_metadata( $post );
+
         echo wp_audio_shortcode( array( 'src' => $att_url ) );
 
     elseif ( $attachment_id && 0 === strpos( $post->post_mime_type, 'video/' ) ):
+
+        maybe_regenerate_attachment_metadata( $post );
 
         $meta = wp_get_attachment_metadata( $attachment_id );

trunk/src/wp-includes/media.php

@@ -2195 +2195 @@
     return empty( $gallery['src'] ) ? array() : $gallery['src'];
 }
+
+/**
+ * If an attachment is missing its metadata, try to regenerate it
+ *
+ * @param post $attachment Post object.
+ */
+function maybe_regenerate_attachment_metadata( $attachment ) {
+    if ( empty( $attachment ) || ( empty( $attachment->ID ) || ! $attachment_id = (int) $attachment->ID ) ) {
+        return;
+    }
+
+    $file = get_attached_file( $attachment_id );
+    $meta = wp_get_attachment_metadata( $attachment_id );
+    if ( empty( $meta ) && file_exists( $file ) ) {
+        $_meta = get_post_meta( $attachment_id );
+        $regeneration_lock = 'wp_regenerating_' . $attachment_id;
+        if ( ! array_key_exists( '_wp_attachment_metadata', $_meta ) && ! get_transient( $regeneration_lock ) ) {
+            set_transient( $regeneration_lock, $file );
+            wp_update_attachment_metadata( $attachment_id, wp_generate_attachment_metadata( $attachment_id, $file ) );
+            delete_transient( $regeneration_lock );
+        }
+    }
+}