Changeset 27127 for trunk/src/wp-admin/includes/media.php

Timestamp:

02/07/2014 10:40:32 PM (11 years ago)

Author:

wonderboymusic

Message:

Introduce maybe_regenerate_attachment_metadata( $attachment ). On the Edit Media screen, call it for Audio and Video files.

The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.

This is the minimum viable product for #26825, but leaving the ticket open unless this function needs to be called in other places.

See #26825.

File:

• trunk/src/wp-admin/includes/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -2637 +2637 @@
     elseif ( $attachment_id && 0 === strpos( $post->post_mime_type, 'audio/' ) ):
 
+        maybe_regenerate_attachment_metadata( $post );
+
         echo wp_audio_shortcode( array( 'src' => $att_url ) );
 
     elseif ( $attachment_id && 0 === strpos( $post->post_mime_type, 'video/' ) ):
+
+        maybe_regenerate_attachment_metadata( $post );
 
         $meta = wp_get_attachment_metadata( $attachment_id );