Changeset 27209

Timestamp:

02/20/2014 05:49:30 PM (13 years ago)

Author:

wonderboymusic

Message:

Allow pseudo post types attachment:audio and attachment:video to get the media modal on Edit Media when they support featured images.

Introduces post_supports_thumbnails( $post ) and theme_supports_thumbnails( $post ) to cut down on duplicated code everytime this needs to be checked. There will be more cases forthcoming.

See #26631.

Location:

trunk/src

Files:

• wp-admin/edit-form-advanced.php (modified) (1 diff)
• wp-includes/media.php (modified) (3 diffs)

trunk/src/wp-admin/edit-form-advanced.php

@@ -25 +25 @@
 $action = isset($action) ? $action : '';
 
-if ( post_type_supports($post_type, 'editor') || post_type_supports($post_type, 'thumbnail') ) {
+$media_type = false;
+if ( 'attachment' && $post_ID ) {
+        $post = get_post( $post_ID );
+        $media_type = post_supports_thumbnails( $post );
+}
+
+if ( post_type_supports( $post_type, 'editor' ) || post_type_supports( $post_type, 'thumbnail' ) || $media_type ) {
         add_thickbox();
         wp_enqueue_media( array( 'post' => $post_ID ) );

trunk/src/wp-includes/media.php

@@ -2013 +2013 @@
                 );
 
-                if ( current_theme_supports( 'post-thumbnails', $post->post_type ) && post_type_supports( $post->post_type, 'thumbnail' ) ) {
+                if ( theme_supports_thumbnails( $post ) && post_supports_thumbnails( $post ) ) {
                         $featured_image_id = get_post_meta( $post->ID, '_thumbnail_id', true );
                         $settings['post']['featuredImageId'] = $featured_image_id ? $featured_image_id : -1;
@@ -2241 +2241 @@
  * If an attachment is missing its metadata, try to regenerate it
  *
+ * @since 3.9.0
+ *
  * @param post $attachment Post object.
  */
@@ -2260 +2262 @@
         }
 }
+
+/**
+ * Determine if a post supports thumbnails based on the passed $post
+ *
+ * @since 3.9.0
+ *
+ * @param WP_Post $post
+ *
+ * @return boolean
+ */
+function post_supports_thumbnails( $post ) {
+        if ( 'attachment' === $post->post_type ) {
+                if ( 0 === strpos( $post->post_mime_type, 'audio' ) ) {
+                        return post_type_supports( 'attachment:audio', 'thumbnail' );
+                } elseif ( 0 === strpos( $post->post_mime_type, 'video' ) ) {
+                        return post_type_supports( 'attachment:video', 'thumbnail' );
+                }
+        }
+
+        return post_type_supports( $post->post_type, 'thumbnail' );
+}
+
+/**
+ * Determine if a theme supports thumbnails based on the passed $post
+ *
+ * @since 3.9.0
+ *
+ * @param WP_Post $post
+ *
+ * @return boolean
+ */
+function theme_supports_thumbnails( $post ) {
+        if ( 'attachment' === $post->post_type ) {
+                if ( 0 === strpos( $post->post_mime_type, 'audio' ) ) {
+                        return current_theme_supports( 'post-thumbnails', 'attachment:audio' );
+                } elseif ( 0 === strpos( $post->post_mime_type, 'video' ) ) {
+                        return current_theme_supports( 'post-thumbnails', 'attachment:video' );
+                }
+        }
+
+        return current_theme_supports( 'post-thumbnails', $post->post_type );
+}