Changeset 27313 for trunk/src/wp-includes/media-template.php

Timestamp:

02/27/2014 07:21:04 PM (13 years ago)

Author:

wonderboymusic

Message:

wp.media.collection should be its own civilized instantiable class, not a wrapper/factory. The class shall contain no reference to specific instances, and shall not try to grab static properties of itself. self, meet this.

See #26631.

File:

• trunk/src/wp-includes/media-template.php (modified) (4 diffs)

trunk/src/wp-includes/media-template.php

@@ -433 +433 @@
 
                 <#
-                        var playlist = 'playlist-edit' === data.controller.id, emptyModel = 'undefined' === typeof data.model.style;
+                        var playlist = 'playlist-edit' === data.controller.id, emptyModel = _.isEmpty(data.model);
                 #>
                 <label class="setting">
                         <span><?php _e( 'Show Tracklist' ); ?></span>
-                        <input type="checkbox" data-setting="_tracklist" <# if ( playlist && emptyModel ) { #>
+                        <input type="checkbox" data-setting="tracklist" <# if ( playlist && emptyModel ) { #>
                                 checked="checked"
                         <# } #> />
@@ -444 +444 @@
                 <label class="setting">
                         <span><?php _e( 'Show Track Numbers' ); ?></span>
-                        <input type="checkbox" data-setting="_tracknumbers" <# if ( playlist && emptyModel ) { #>
+                        <input type="checkbox" data-setting="tracknumbers" <# if ( playlist && emptyModel ) { #>
                                 checked="checked"
                         <# } #> />
@@ -451 +451 @@
                 <label class="setting">
                         <span><?php _e( 'Show Artist Name in Tracklist' ); ?></span>
-                        <input type="checkbox" data-setting="_artists" <# if ( playlist && emptyModel ) { #>
+                        <input type="checkbox" data-setting="artists" <# if ( playlist && emptyModel ) { #>
                                 checked="checked"
                         <# } #> />
@@ -458 +458 @@
                 <label class="setting">
                         <span><?php _e( 'Show Images' ); ?></span>
-                        <input type="checkbox" data-setting="_images" <# if ( emptyModel ) { #>
+                        <input type="checkbox" data-setting="images" <# if ( emptyModel ) { #>
                                 checked="checked"
                         <# } #> />