Changeset 27366

Timestamp:

03/03/2014 01:14:27 AM (11 years ago)

Author:

azaozz

Message:

Editor: when TinyMCE is used, add autocomplete="off" to the textarea to prevent problems with missing <p> tags when the user reloads the page or uses Go Back/Go Forward buttons, and when editing the same post from two different windows. The autocomplete can be removed with the the_editor filter. Part props xsonic, fixes #27251.

File:

• trunk/src/wp-includes/class-wp-editor.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-editor.php

@@ -88 +88 @@
     public static function editor( $content, $editor_id, $settings = array() ) {
 
-        $set = self::parse_settings($editor_id, $settings);
+        $set = self::parse_settings( $editor_id, $settings );
         $editor_class = ' class="' . trim( $set['editor_class'] . ' wp-editor-area' ) . '"';
         $tabindex = $set['tabindex'] ? ' tabindex="' . (int) $set['tabindex'] . '"' : '';
         $switch_class = 'html-active';
-        $toolbar = $buttons = '';
+        $toolbar = $buttons = $autocomplete = '';
 
         if ( ! empty( $set['editor_height'] ) )
@@ -104 +104 @@
         if ( ! self::$this_quicktags && self::$this_tinymce ) {
             $switch_class = 'tmce-active';
+            $autocomplete = ' autocomplete="off"';
         } elseif ( self::$this_quicktags && self::$this_tinymce ) {
             $default_editor = $set['default_editor'] ? $set['default_editor'] : wp_default_editor();
+            $autocomplete = ' autocomplete="off"';
 
             // 'html' is used for the "Text" editor tab.
@@ -148 +150 @@
         }
 
-        $the_editor = apply_filters('the_editor', '<div id="wp-' . $editor_id . '-editor-container" class="wp-editor-container"><textarea' . $editor_class . $height . $tabindex . ' cols="40" name="' . $set['textarea_name'] . '" id="' . $editor_id . '">%s</textarea></div>');
-        $content = apply_filters('the_editor_content', $content);
-
-        printf($the_editor, $content);
+        $the_editor = apply_filters( 'the_editor', '<div id="wp-' . $editor_id . '-editor-container" class="wp-editor-container">' .
+            '<textarea' . $editor_class . $height . $tabindex . $autocomplete . ' cols="40" name="' . $set['textarea_name'] . '" ' .
+            'id="' . $editor_id . '">%s</textarea></div>' );
+        $content = apply_filters( 'the_editor_content', $content );
+
+        printf( $the_editor, $content );
         echo "\n</div>\n\n";