Changeset 27394

Timestamp:

03/04/2014 07:10:46 AM (11 years ago)

Author:

nacin

Message:

Bail early from shortcode functions if no delimiter is present.

This is a significant performance improvement for processing content without shortcodes, and only the slightest hit when content contains shortcodes (which must then undergo processing anyway). Performance results on the ticket.

props TobiasBg.
fixes #23855.

File:

• trunk/src/wp-includes/shortcodes.php (modified) (3 diffs)

trunk/src/wp-includes/shortcodes.php

@@ -156 +156 @@
  */
 function has_shortcode( $content, $tag ) {
+    if ( false === strpos( $content, '[' ) ) {
+        return false;
+    }
+
     if ( shortcode_exists( $tag ) ) {
         preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER );
@@ -186 +190 @@
 function do_shortcode($content) {
     global $shortcode_tags;
+
+    if ( false === strpos( $content, '[' ) ) {
+        return $content;
+    }
 
     if (empty($shortcode_tags) || !is_array($shortcode_tags))
@@ -376 +384 @@
     global $shortcode_tags;
 
+    if ( false === strpos( $content, '[' ) ) {
+        return $content;
+    }
+
     if (empty($shortcode_tags) || !is_array($shortcode_tags))
         return $content;