Changeset 27470

Timestamp:

03/08/2014 04:18:30 AM (13 years ago)

Author:

nacin

Message:

Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context.

see #13265.

Location:

trunk/src

Files:

• wp-admin/includes/meta-boxes.php (modified) (1 diff)
• wp-admin/includes/template.php (modified) (1 diff)
• wp-admin/includes/theme.php (modified) (1 diff)
• wp-includes/class-wp-theme.php (modified) (3 diffs)
• wp-includes/post.php (modified) (1 diff)

trunk/src/wp-admin/includes/meta-boxes.php

@@ -706 +706 @@
                 } // end empty pages check
         } // end hierarchical check.
-        if ( 'page' == $post->post_type && 0 != count( get_page_templates() ) ) {
+        if ( 'page' == $post->post_type && 0 != count( get_page_templates( $post ) ) ) {
                 $template = !empty($post->page_template) ? $post->page_template : false;
                 ?>

trunk/src/wp-admin/includes/template.php

@@ -742 +742 @@
  */
 function page_template_dropdown( $default = '' ) {
-        $templates = get_page_templates();
+        $templates = get_page_templates( get_post() );
         ksort( $templates );
         foreach ( array_keys( $templates ) as $template ) {

trunk/src/wp-admin/includes/theme.php

@@ -79 +79 @@
  * @since 1.5.0
  *
+ * @param WP_Post|null $post Optional. The post being edited, provided for context.
  * @return array Key is the template name, value is the filename of the template
  */
-function get_page_templates() {
-        return array_flip( wp_get_theme()->get_page_templates() );
+function get_page_templates( $post = null ) {
+        return array_flip( wp_get_theme()->get_page_templates( $post ) );
 }
 

trunk/src/wp-includes/class-wp-theme.php

@@ -932 +932 @@
          * @access public
          *
+         * @param WP_Post|null $post Optional. The post being edited, provided for context.
          * @return array Array of page templates, keyed by filename, with the value of the translated header name.
          */
-        public function get_page_templates() {
+        public function get_page_templates( $post = null ) {
                 // If you screw up your current theme and we invalidate your parent, most things still work. Let it slide.
                 if ( $this->errors() && $this->errors()->get_error_codes() !== array( 'theme_parent_invalid' ) )
@@ -962 +963 @@
 
                 if ( $this->parent() )
-                        $page_templates += $this->parent()->get_page_templates();
+                        $page_templates += $this->parent()->get_page_templates( $post );
 
                 /**
@@ -971 +972 @@
                  * @since 3.9.0
                  *
-                 * @param array    $page_templates Array of page templates. Keys are filenames,
-                 *                                 values are translated names.
-                 * @param WP_Theme $this           The theme object.
+                 * @param array        $page_templates Array of page templates. Keys are filenames,
+                 *                                     values are translated names.
+                 * @param WP_Theme     $this           The theme object.
+                 * @param WP_Post|null $post           The post being edited, provided for context, or null.
                  */
-                $return = apply_filters( 'page_templates', $page_templates, $this );
+                error_log( serialize( $this ) );
+                $return = apply_filters( 'theme_page_templates', $page_templates, $this, $post );
                 return array_intersect_assoc( $return, $page_templates );
         }

trunk/src/wp-includes/post.php

@@ -2949 +2949 @@
         if ( !empty($page_template) && 'page' == $data['post_type'] ) {
                 $post->page_template = $page_template;
-                $page_templates = wp_get_theme()->get_page_templates();
+                $page_templates = wp_get_theme()->get_page_templates( $post );
                 if ( 'default' != $page_template && ! isset( $page_templates[ $page_template ] ) ) {
                         if ( $wp_error )