Changeset 27519 for trunk/src/wp-includes/media.php

Timestamp:

03/13/2014 03:41:53 AM (12 years ago)

Author:

wonderboymusic

Message:

Account for preload="metadata" in audio and video shortcodes when multiple versions of the same <source> appear on the page by appending a query arg to "cache-bust" passed sources. The query arg is used to make the sources "unique." They will still be cached by the browser and won't bust the cache on every request.

Fixes #26779.

File:

• trunk/src/wp-includes/media.php (modified) (2 diffs)

trunk/src/wp-includes/media.php

@@ -1470 +1470 @@
                                 $fileurl = $$fallback;
                         $type = wp_check_filetype( $$fallback, wp_get_mime_types() );
-                        $html .= sprintf( $source, $type['type'], esc_url( $$fallback ) );
+                        $url = add_query_arg( '_', $instances, $$fallback );
+                        $html .= sprintf( $source, $type['type'], esc_url( $url ) );
                 }
         }
@@ -1658 +1659 @@
                                 $type = wp_check_filetype( $$fallback, wp_get_mime_types() );
                         }
-                        $html .= sprintf( $source, $type['type'], esc_url( $$fallback ) );
+                        $url = add_query_arg( '_', $instances, $$fallback );
+                        $html .= sprintf( $source, $type['type'], esc_url( $url ) );
                 }
         }