Changeset 27523

Timestamp:

03/13/2014 05:38:51 PM (11 years ago)

Author:

johnbillion

Message:

Improve paginate_links() performance by not calling number_format_i18n() unnecessarily. Fixes #25735 with tests. Props johnpbloch.

Location:

trunk

Files:

• src/wp-includes/general-template.php (modified) (2 diffs)
• tests/phpunit/tests/general/template.php (added)

trunk/src/wp-includes/general-template.php

@@ -2031 +2031 @@
     endif;
     for ( $n = 1; $n <= $total; $n++ ) :
-        $n_display = number_format_i18n($n);
         if ( $n == $current ) :
-            $page_links[] = "<span class='page-numbers current'>$n_display</span>";
+            $page_links[] = "<span class='page-numbers current'>" . number_format_i18n($n) . "</span>";
             $dots = true;
         else :
@@ -2042 +2041 @@
                     $link = add_query_arg( $add_args, $link );
                 $link .= $add_fragment;
-                $page_links[] = "<a class='page-numbers' href='" . esc_url( apply_filters( 'paginate_links', $link ) ) . "'>$n_display</a>";
+                $page_links[] = "<a class='page-numbers' href='" . esc_url( apply_filters( 'paginate_links', $link ) ) . "'>" . number_format_i18n($n) . "</a>";
                 $dots = true;
             elseif ( $dots && !$show_all ) :