Changeset 27554

Timestamp:

03/15/2014 05:08:40 AM (11 years ago)

Author:

nacin

Message:

XML-RPC: In wp.editPost, Remove all terms in a taxonomy when an empty array is explicitly passed.

props jstraitiff, maxcutler.
fixes #26686.

Location:

trunk

Files:

• src/wp-includes/class-wp-xmlrpc-server.php (modified) (1 diff)
• tests/phpunit/tests/xmlrpc/wp/editPost.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -1132 +1132 @@
 
                     $term_ids = $post_data['terms'][$taxonomy];
+                    $terms[ $taxonomy ] = array();
                     foreach ( $term_ids as $term_id ) {
                         $term = get_term_by( 'id', $term_id, $taxonomy );

trunk/tests/phpunit/tests/xmlrpc/wp/editPost.php

@@ -310 +310 @@
 
     /**
+     * @ticket 26686
+     */
+    function test_clear_categories_on_edit() {
+        $editor_id = $this->make_user_by_role( 'editor' );
+
+        $post_id = $this->factory->post->create( array( 'post_author'  => $editor_id ) );
+        $term_id = $this->factory->category->create();
+        $this->factory->term->add_post_terms( $post_id, $term_id, 'category', true );
+        $term_ids = wp_list_pluck( get_the_category( $post_id ), 'term_id' );
+        $this->assertContains( $term_id, $term_ids );
+
+        $new_post_content = array(
+            'ID' => $post_id,
+            'post_title' => 'Updated',
+            'terms' => array(
+                'category' => array()
+            )
+        );
+        $result = $this->myxmlrpcserver->wp_editPost( array( 1, 'editor', 'editor', $post_id, $new_post_content ) );
+        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertEquals( 'Updated', get_post( $post_id )->post_title );
+
+        $term_ids = wp_list_pluck( get_the_category( $post_id ), 'term_id' );
+        $this->assertNotContains( $term_id, $term_ids );
+    }
+
+    /**
      * @ticket 23219
      */