Changeset 27562

Timestamp:

03/17/2014 07:39:31 PM (11 years ago)

Author:

nacin

Message:

Return false from metadata_exists() if the get_$type_metadata filter returns a false value.

props xknown.
fixes #22746.

Location:

trunk

Files:

• src/wp-includes/meta.php (modified) (1 diff)
• tests/phpunit/tests/meta.php (modified) (1 diff)

trunk/src/wp-includes/meta.php

@@ -324 +324 @@
     $check = apply_filters( "get_{$meta_type}_metadata", null, $object_id, $meta_key, true );
     if ( null !== $check )
-        return true;
+        return (bool) $check;
 
     $meta_cache = wp_cache_get( $object_id, $meta_type . '_meta' );

trunk/tests/phpunit/tests/meta.php

@@ -82 +82 @@
         $this->assertFalse( metadata_exists( 'user',  1234567890, 'foobarbaz' ) );
         $this->assertFalse( metadata_exists( 'user',  1234567890, 'meta_key' ) );
+    }
+
+    /**
+     * @ticket 22746
+     */
+    function test_metadata_exists_with_filter() {
+        // Let's see if it returns the correct value when adding a filter.
+        add_filter( 'get_user_metadata', '__return_zero' );
+        $this->assertFalse( metadata_exists( 'user', $this->author->ID, 'meta_key' ) ); // existing meta key
+        $this->assertFalse( metadata_exists( 'user', 1234567890, 'meta_key' ) );
+        remove_filter( 'get_user_metadata', '__return_zero' );
     }