Changeset 27580 for trunk/src/wp-includes/media-template.php

Timestamp:

03/18/2014 03:24:17 AM (12 years ago)

Author:

azaozz

Message:

TinyMCE gallery preview: fix errors when an image doesn't have/is smaller than thumbnail size, props gcorne, see #26959

File:

• trunk/src/wp-includes/media-template.php (modified) (3 diffs)

trunk/src/wp-includes/media-template.php

@@ -898 +898 @@
         </div>
     </script>
-    <?php
-
-        //TODO: do we want to deal with the fact that the elements used for gallery items are filterable and can be overriden via shortcode attributes
-        // do we want to deal with the difference between display and edit context at all? (e.g. wptexturize() being applied to the caption.
-    ?>
-
     <script type="text/html" id="tmpl-editor-gallery">
         <div class="toolbar">
@@ -913 +907 @@
                 <dl class="gallery-item">
                     <dt class="gallery-icon">
-                        <?php // TODO: need to figure out the best way to make sure that we have thumbnails ?>
-                        <img src="{{{ attachment.sizes.thumbnail.url }}}" />
+                        <img src="{{{ attachment.thumbnail.url }}}" width="{{ attachment.thumbnail.width }}" height="{{ attachment.thumbnail.height }}" />
                     </dt>
                     <dd class="wp-caption-text gallery-caption">
@@ -920 +913 @@
                     </dd>
                 </dl>
-                <?php // this is kind silly, but copied from the gallery shortcode. Maybe it should be removed ?>
                 <# if ( index % data.columns === data.columns - 1 ) { #>
                     <br style="clear: both;">